Skip to content

fix(ui): say the downloaded file is incomplete when an export fails #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmaclennan merged 1 commit into from
Sep 17, 2026
Merged

fix(ui): say the downloaded file is incomplete when an export fails #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions e2e/app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,9 @@ describeEngines((engine) => {
await page.click("#cancel");

await page.waitForSelector('[data-message="error"]');
expect(await page.textContent('[data-message="error"]')).toContain(
"cancelled",
);
const message = await page.textContent('[data-message="error"]');
expect(message).toContain("cancelled");
expect(message).toContain("incomplete");
await page.waitForSelector('[role="progressbar"]', { state: "detached" });
await page.waitForSelector("#export:not([disabled])");
});
Expand Down
9 changes: 8 additions & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,14 @@ function start(app: HTMLElement) {
form.message = null;
}, SAVED_MESSAGE_MS);
} catch (err) {
form.message = { kind: "error", text: describe(err) };
// The download had already started, and iOS keeps whatever was flushed.
const reached = Math.round(form.progress * 100);
form.message = {
kind: "error",
text:
`${describe(err)} (stopped at ${reached}%). ` +
"Any file that was downloaded is incomplete — delete it and try again.",
};
} finally {
form.exporting = false;
form.progress = 0;
Expand Down