Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
===========================================
+ Coverage 62.24% 74.44% +12.20%
===========================================
Files 159 144 -15
Lines 13417 11295 -2122
===========================================
+ Hits 8351 8409 +58
+ Misses 5066 2886 -2180 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Destructive firmware behavior requires hardware validation and human review, and the password-limit compatibility issue remains unresolved.
1 open issue
2 files not reviewed
internal/mocks/devicemanagement_mocks.go: Generated fileinternal/mocks/wsman_mocks.go: Generated file
What changed in this PR
Updates Remote Platform Erase to deliver drive credentials to BIOS and expose the last BIOS erase status.
Changes:
- Encodes SSD passwords and optional PSIDs in boot parameters.
- Adds a v2 erase-status endpoint.
- Updates tests, mocks, API documentation, and coverage exclusions.
| File | Description |
|---|---|
| internal/usecase/devices/wsman/rpe.go | Encodes and validates drive credentials. |
| internal/usecase/devices/wsman/rpe_test.go | Tests credential encoding and limits. |
| internal/usecase/devices/wsman/interfaces.go | Adds the PSID argument. |
| internal/usecase/devices/interfaces.go | Exposes erase-status retrieval. |
| internal/usecase/devices/boot.go | Validates credentials and interprets BIOS status. |
| internal/usecase/devices/boot_test.go | Tests status handling and credential forwarding. |
| internal/mocks/wsman_mocks.go | Updates credential method mocks. |
| internal/mocks/devicemanagement_mocks.go | Adds erase-status mocks. |
| internal/entity/dto/v2/remoteerase.go | Defines the status response. |
| internal/entity/dto/v1/bootcapabilities.go | Adds optional PSID input. |
| internal/controller/openapi/devicemanagement.go | Documents credentials and status retrieval. |
| internal/controller/httpapi/v2/devicemanagement.go | Adds the status handler. |
| internal/controller/httpapi/v2/devicemanagement_test.go | Tests status and error responses. |
| internal/controller/httpapi/v1/boot_test.go | Verifies PSID forwarding. |
| integration-test/collections/console_mps_apis.postman_collection.json | Updates erase requests and documentation. |
| codecov.yml | Excludes generated mocks from coverage. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Credential delivery and BIOS-status interpretation for destructive erase operations require hardware-backed validation and human review.
No open issues 🎉
1 resolved since last review
2 files not reviewed
internal/mocks/devicemanagement_mocks.go: Generated fileinternal/mocks/wsman_mocks.go: Generated file
Review effort: Balanced
nmgaston
force-pushed
the
fixRPEWithEncryptedSSD
branch
from
October 20, 2026 01:34
b115cda to
24348c4
Compare
3 of 4 tasks
nmgaston
marked this pull request as ready for review
October 20, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for password-protected SSDs during RPE by sending the SSD password to the BIOS so those drives can be accessed/managed correctly during the process.
Also adds a new API GET remoteEraseStatus to allow a more accurate status of the RPE request.
Associated with the UI changes: device-management-toolkit/sample-web-ui#3655
Does not require the UI changes to be checked in to fix the password issue. It will allow polling to give a more accurate state of the RPE request.