fix(node): Refresh inherited Yarn APT keyrings before dependencies - #1746
Open
Jerome Brown (oWretch) wants to merge 1 commit into
Open
Jerome Brown (oWretch) wants to merge 1 commit into
Jerome Brown (oWretch) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh an inherited Yarn APT repository before Node feature prerequisite installation can run apt-get update. Reuse the same repository setup for fresh APT-based Yarn installations.
Problem
Older devcontainer images already contain Yarn and an unmanaged signing keyring. The installer skips repository setup when Yarn is already installed, so adding the feature does not refresh inherited trust data. Prerequisite installation can also invoke APT before install_yarn runs. This breaks unrelated package installation after upstream key rotation, even when the feature uses the default Corepack mode.
Reproduced with mcr.microsoft.com/devcontainers/python:1.2.8-3.13-bookworm and NO_PUBKEY 62D54FD4003F6525. Related: devcontainers/images#1752, devcontainers/images#1797, and #1547. This does not request disabling signature verification or changing historical image tags.
Changes
Validation