Skip to content

Show a loading state on the project metrics tabs - #349

Merged
acoshift merged 1 commit into
mainfrom
metrics-tab-loading
Nov 3, 2026
Merged

acoshift merged 1 commit into
mainfrom
metrics-tab-loading

Conversation

@acoshift

@acoshift acoshift commented Nov 3, 2026

Copy link
Copy Markdown
Member

Summary

  • The project metrics page and the By deployment tab show a loading status instead of empty charts while project.metrics or project.metricsByDeployment is in flight.
  • A slower response cannot overwrite a newer range, or a tab the user has already left.

Test plan

  • bun run check
  • Mock console: Project shows "Loading metrics…" and then the project charts. By deployment does the same, then shows per-deployment series. Switching back and changing the range shows the loading status again.
  • After deploy, open Metrics → By deployment on a project whose request takes a few seconds. The loading status stays up until the charts appear.

Requested via Grok Work
Prompter: ACS
Session: 645a56c8-b327-49db-a9f4-f98786a9c90f

Both the project view and the by-deployment view rendered empty charts until the request returned. By deployment can take a while, so that looked like there was no data. Show a loading status until the current request settles, and ignore a response that arrives after a newer fetch or after leaving the tab.

Prompter: ACS
@deploys-app
deploys-app Bot temporarily deployed to pr-349 November 3, 2026 07:17 Destroyed
@deploys-app

deploys-app Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Preview deleted (PR closed).

@acoshift
acoshift merged commit d6070c8 into main Nov 3, 2026
5 checks passed
@acoshift
acoshift deleted the metrics-tab-loading branch November 3, 2026 08:11

This branch was successfully deployed

No deployments
pr-349 — 58e39eca Deployed Nov 3, 2026 by deploys-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant