Repository navigation
Fix: complete B-spline integer-point sum in Structure_Factor::bsplinecoef - #8209
Closed
Cstandardlib wants to merge 2 commits into
Closed
Cstandardlib wants to merge 2 commits into
Cstandardlib wants to merge 2 commits into
Conversation
Cstandardlib
changed the title
Structure_Factor::bsplinecoef
Cstandardlib
marked this pull request as draft
October 23, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing last term in B-spline deconvolution factor for structure factor (nbspline).
Summary
When
nbspline = Nis set,Structure_Factor::bsplinecoefthe denominator loop wasfor (int io = 0; io < norder - 1; ++io), which drops the last integer-point sampleM_{N+1}(N) = 1/N!of the Cardinal B-spline. Fix it.Linked Issue
Fix #8092
Unit Tests and/or Case Tests for my changes
What's changed?
Governance Notes