Repository navigation
Conversation
Growl1234
added
Refactor
mohanchen
reviewed
Oct 21, 2026
| this->inp_->out_pchg, | ||
| global_out_dir, | ||
| GlobalV::ofs_running); | ||
| get_pchg |
Collaborator
There was a problem hiding this comment.
it is strange to split the function call into two lines
Collaborator
Author
There was a problem hiding this comment.
Honestly I'm a bit confused too. Who knows what clang-format considers "pretty" 🙃
Growl1234
changed the title
Collaborator
|
@ABACUS-PR-BOT Please take a final review on this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
Fix #
Unit Tests and/or Case Tests for my changes
What's changed?
Governance Notes