Skip to content

CMake: Prepare test scripts and data at configure time - #8161

Open
Growl1234 wants to merge 1 commit into
deepmodeling:developfrom
Growl1234:cmake
Open

Growl1234 wants to merge 1 commit into
deepmodeling:developfrom
Growl1234:cmake

Conversation

@Growl1234

Copy link
Copy Markdown

Prepare test scripts and data at configure time so CTest can run directly after building but before installing.

  • Track resource changes and remove redundant test installation rules.
  • Use consistent working directories and target paths for multi-config builds.
  • Register the 3-rank and 4-rank PW tests separately.

@mohanchen mohanchen added Tests/Examples Issues/PR related to unit tests and integrate tests Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS labels Oct 17, 2026

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review completed at a5d72ec6; no confirmed implementation defect was found.

Non-blocking: Please add the exact configure/build/CTest commands and observed results to the PR description, including CTest without installation and any resource-refresh or multi-config cases checked; explicitly note untested combinations. A small regression check for abacus_copy_test_files can follow after merge.

Builds/runtime tests were not run, and CI verification was unavailable.

@Growl1234

Growl1234 commented Oct 18, 2026 •

Copy link
Copy Markdown
Author

Non-blocking: Please add the exact configure/build/CTest commands and observed results to the PR description, including CTest without installation and any resource-refresh or multi-config cases checked

I modified the Test workflow so the results should be clear in CI.

For developers/users, nothing to adjust, but they can now run ctest without installing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS Tests/Examples Issues/PR related to unit tests and integrate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants