Skip to content

tools: refactor code-quality scorer and add header/macro/PARAM rules #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohanchen merged 5 commits into from
Oct 17, 2026
Merged

tools: refactor code-quality scorer and add header/macro/PARAM rules #8158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfecaf3
refactor(tools): split code_quality_score.py into focused cqs_* modules
Oct 16, 2026
f005fb6
feat(tools): score header length and non-inline header function bodies
Oct 16, 2026
ebb2716
feat(tools): score new #define macros and PARAM member init (rules 16…
Oct 16, 2026
f8290d5
Merge branch 'upstream/develop' into 2026-10-16-a
Oct 17, 2026
abf4dc3
fix(tools): address review comments on code-quality scorer
Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ rules. Read the complete governance document before making or reviewing changes:
the stream state (`fail()`/`eof()`) after extraction and abort with a
diagnostic message on malformed input rather than silently defaulting
to zero.
20. Do not introduce new `#define` macros without approval. Include
guards and `#ifdef`/`#ifndef` usages of existing macros are exempt.
21. Do not initialize member variables from `PARAM` in `.h`/`.hpp`
files; pass the value through the constructor or a setter instead.
- Use LF line endings for text files. Only `.bat` and `.cmd` files may use CRLF.
- Keep source file additions deterministic: update the relevant `CMakeLists.txt`
or explain why the file is generated or included indirectly.
Expand Down
Loading
Loading