Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 65.19% 68.29% +3.10%
==========================================
Files 37 37
Lines 1879 2022 +143
Branches 230 247 +17
==========================================
+ Hits 1225 1381 +156
+ Misses 602 588 -14
- Partials 52 53 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add equilibrium bond-length and well-depth errors to the existing 14 MLIP Arena diatomic references. The reference JSON, original finite-difference roughness formula, and removal of the last scan point remain unchanged. All three metrics use the same trimmed distances.
Bond length uses a local quadratic fit around the sampled minimum, with a midpoint guess for flat predictions. References with depth below 0.05 eV skip bond position but still score well depth. Well depth is the energy difference between the last retained point and the sampled minimum, not an infinite-separation dissociation energy.
Normalize and cap each molecule's errors against a midpoint-position dummy and a constant-energy dummy, then average across molecules. The leaderboard reports the equal-weight average of roughness, bond-length score, and well-depth score in [0, 1], lower being better. Any missing/failed molecule prevents a combined score.
Inference saves its exact reference molecule list and per-molecule dummy errors, so custom references aggregate against their own test set. Legacy roughness-only records remain readable but require recomputation for the combined score. The leaderboard column becomes Applicability-Diatomics.
Validation
The repository-wide pre-commit check also reports existing baseline violations in database setup and unrelated portions of metrics/utils.py (including UP031, SIM115, C403, SIM118 and PERF102). These are outside this PR's scope; the changed-code local Ruff checks pass.
Replaces the approach in closed #456 without replacing the reference data.