Repository navigation

Rebuild the form editor as one document - #282

Merged

PhilReinking merged 194 commits into

mainfrom

land/bits-274-editor

Oct 13, 2026

Merged

Rebuild the form editor as one document#282
PhilReinking merged 194 commits into
mainfrom
land/bits-274-editor

Commits on Oct 12, 2026
- feat: edit the whole form as one document
  
  PhilReinking
  and
  claude
  committed
  e9005ee
- feat: put grip and delete inside each choice row
  
  PhilReinking
  and
  claude
  committed
  ef0663e
- fix: name the text format buttons
  
  PhilReinking
  and
  claude
  committed
  d32b49c
- Merge branch 'feat/bits-275-duplicate-question' into stack/bits-274-phase-1
  PhilReinking
  committed
  7369274
- Merge branch 'fix/bits-281-editor-loading' into stack/bits-274-phase-1
  PhilReinking
  committed
  730f369
- Merge branch 'stack/bits-274-phase-1' into feat/bits-282-document-editor
  
  PhilReinking
  and
  claude
  committed
  c744234
- fix: focus after Try again, and drop a late question load
  
  PhilReinking
  and
  claude
  committed
  4bcf889
- test: cover the closed question row and opening it
  
  PhilReinking
  and
  claude
  committed
  c18216f
- docs: add changelog line for #268
  
  PhilReinking
  and
  claude
  committed
  d32d1cd
- fix: scroll a question opened by link into view
  
  PhilReinking
  and
  claude
  committed
  d61a7c2
- feat: add an outline to jump to a question
  
  PhilReinking
  and
  claude
  committed
  3943fa4
- feat: open a question's settings as a bottom sheet on phones
  
  PhilReinking
  and
  claude
  committed
  1c57ee6
- fix: make the editor's controls 44 px on phones
  
  PhilReinking
  and
  claude
  committed
  91186a3
- fix: keep the top of the document in view on load
  
  PhilReinking
  and
  claude
  committed
  8644f3d
- fix: make a question's answer field without opening Settings
  
  PhilReinking
  and
  claude
  committed
  efc4407
- fix: give the Settings panel the id its button points at
  
  PhilReinking
  and
  claude
  committed
  c00f13e
- fix: let a group be dragged by a grip in its header
  
  PhilReinking
  and
  claude
  committed
  651590b
- fix: keep focus near a deleted choice or policy
  
  PhilReinking
  and
  claude
  committed
  20608c4
- fix: leave the cursor alone when a new question can't be made
  
  PhilReinking
  and
  claude
  committed
  7bdefa3
- refactor: drop form store state the old storyboard used
  
  PhilReinking
  and
  claude
  committed
  a7fa8d5
- Merge branch 'fix/bits-276-rule-references' into stack/bits-274-phase-1
  PhilReinking
  committed
  66d0ba1
- Merge branch 'feat/bits-277-preview-mode' into stack/bits-274-phase-1
  PhilReinking
  committed
  b43958c
- Merge branch 'stack/bits-274-phase-1' into feat/bits-282-document-editor
  PhilReinking
  committed
  e4fc5f5
- Merge branch 'feat/bits-282-document-editor' into feat/bits-282b-outline-phone
  PhilReinking
  committed
  9e58fb5
- fix: hide the group grip on phones, like the question grip
  
  PhilReinking
  and
  claude
  committed
  1949324
- fix: move between visible choices only, with a custom answer on
  
  PhilReinking
  and
  claude
  committed
  e1fed98
- fix: show a question's text flat in its card, without boxes
  
  PhilReinking
  and
  claude
  committed
  359284d
- fix: draw each choice as one row, and name its fields
  
  PhilReinking
  and
  claude
  committed
  6ae1bd8
- fix: say "Add choice", as a dashed row like the concept
  
  PhilReinking
  and
  claude
  committed
  a960f5c
- fix: hide Required on a No Input question
  
  PhilReinking
  and
  claude
  committed
  7930924
- fix: make a choice row 36 px tall, like the concept
  
  PhilReinking
  and
  claude
  committed
  3938f6b
- Merge branch 'feat/bits-282-document-editor' into feat/bits-282b-outline-phone
  PhilReinking
  committed
  ffcd480
- fix: keep 44 px targets up to 1024 px, and 44 px menu items
  
  PhilReinking
  and
  claude
  committed
  c0d4a20
- Merge branch 'feat/bits-278-top-bar' into stack/bits-274-phase-1
  PhilReinking
  committed
  d472078
- Merge branch 'feat/bits-285-preview-app' into stack/bits-274-phase-1
  PhilReinking
  committed
  2f7ecf9
- Merge branch 'stack/bits-274-phase-1' into feat/bits-282-document-editor
  PhilReinking
  committed
  18c92f9
- Merge branch 'feat/bits-282-document-editor' into feat/bits-282b-outline-phone
  PhilReinking
  committed
  6927dc7
Commits on Oct 13, 2026
- feat: show the end screen as the last block of the document
  
  PhilReinking
  and
  claude
  committed
  ac1aef3
- Merge remote-tracking branch 'origin/feat/bits-282-document-editor' into feat/bits-286-end-screen
  PhilReinking
  committed
  819c489
- docs: add the end screen block to the changelog
  
  PhilReinking
  and
  claude
  committed
  ec80e90
- fix: 44 px fields with 16 px text in the question card below 1024 px
  
  PhilReinking
  and
  claude
  committed
  2c53510
- fix: show a blue bar while the question text has focus
  
  PhilReinking
  and
  claude
  committed
  a9368ce
- fix: add a policy with a dashed row, like Add choice
  
  PhilReinking
  and
  claude
  committed
  d7d794f
- fix: size the app to the visible screen on iPhone Safari (100dvh)
  
  PhilReinking
  and
  claude
  committed
  b516020
- fix: keep the Outline button 44 px below 1024 px
  
  PhilReinking
  and
  claude
  committed
  bc69718
- style: re-indent FormDocument's template (Prettier)
  
  PhilReinking
  and
  claude
  committed
  ea36e24
- style: wrap a long line in DocumentQuestion (Prettier)
  
  PhilReinking
  and
  claude
  committed
  62c5024
- docs: add the outline and phone Settings to the changelog line (#272)
  
  PhilReinking
  and
  claude
  committed
  3945f4c
- feat: show a live preview beside the document
  
  PhilReinking
  and
  claude
  committed
  a2f0513
- feat: say in the form's preview that answers aren't saved
  
  PhilReinking
  and
  claude
  committed
  bbfa3ed
- fix: load the form again when browser Back returns to Settings
  
  PhilReinking
  and
  claude
  committed
  32143ee
- fix: save the end screen when its Settings link or browser Back leaves the page
  
  PhilReinking
  and
  claude
  committed
  ab05962
- style: make the open end screen card flat like a question card
  
  PhilReinking
  and
  claude
  committed
  c6a8d88
- fix: show the default end screen headline people see when it's empty
  
  PhilReinking
  and
  claude
  committed
  f08f890
- feat: put Preview beside the question count on a phone
  
  PhilReinking
  and
  claude
  committed
  f750209
- docs: add changelog line for #273
  
  PhilReinking
  and
  claude
  committed
  cbfd30d
- fix: load the form again when browser Back returns to the editor
  
  PhilReinking
  and
  claude
  committed
  dd3ac2f
- feat: move a block one step and read out where it went
  
  PhilReinking
  and
  claude
  committed
  4421fce
- feat: move a question or group with Alt+Up/Down, close a question with Escape
  
  PhilReinking
  and
  claude
  committed
  51aee37
- feat: read and edit logic rules as sentences
  
  PhilReinking
  and
  claude
  committed
  06bc84b
- feat: show rules where they act in the document
  
  PhilReinking
  and
  claude
  committed
  2d8f4ba
- fix: 44 px outline rows and Close below 1024, drop the sheet's drag handle
  
  PhilReinking
  and
  claude
  committed
  ecc9d3a
- Merge part b's design fix into part c
  PhilReinking
  committed
  054c805
- feat: Move up and Move down in a question's and a group's menu
  
  PhilReinking
  and
  claude
  committed
  652a9ce
- feat: the outline scrolls to the open question
  
  PhilReinking
  and
  claude
  committed
  2a4f4c5
- fix: open the top bar's Preview links in preview mode
  
  PhilReinking
  and
  claude
  committed
  de485c2
- feat: move a choice with Alt+Up/Down
  
  PhilReinking
  and
  claude
  committed
  7f73be2
- fix: give focus back to Settings when the phone sheet closes
  
  PhilReinking
  and
  claude
  committed
  711992e
- fix: put focus back on the phone's Preview after the panel closes
  
  PhilReinking
  and
  claude
  committed
  e75dc55
- Merge part b's review fix into part c
  PhilReinking
  committed
  af3b8dd
- feat: name and group the answer types, one icon each
  
  PhilReinking
  and
  claude
  committed
  2de3109
- feat: add a type picker grouped as Text, Choice, Rating, Other, Content
  
  PhilReinking
  and
  claude
  committed
  39d3850
- feat: add a question anywhere through the type picker
  
  PhilReinking
  and
  claude
  committed
  68b2b3f
- feat: type / in an empty question to pick its answer type
  
  PhilReinking
  and
  claude
  committed
  6069071
- fix: a tooltip no longer takes the keyboard focus
  
  PhilReinking
  and
  claude
  committed
  986acfb
- fix: Escape in the question text closes the question
  
  PhilReinking
  and
  claude
  committed
  b9b36de
- fix: give the phone's Preview a 44 px tap area
  
  PhilReinking
  and
  claude
  committed
  4964034
- fix: close the preview when the window gets narrower than a desktop
  
  PhilReinking
  and
  claude
  committed
  7baa898
- fix: rule editor details found in the browser
  
  PhilReinking
  and
  claude
  committed
  92367af
- feat: say "Add a question to see it here." in an empty form's preview
  
  PhilReinking
  and
  claude
  committed
  98562b3
- refactor: remove the old logic panel
  
  PhilReinking
  and
  claude
  committed
  65b53c0
- fix: reload the form after Back only once the end screen save has landed
  
  PhilReinking
  and
  claude
  committed
  0e89538
- feat: say which question the preview shows, and when a rule hides the open one
  
  PhilReinking
  and
  claude
  committed
  852103e
- Merge remote-tracking branch 'origin/feat/bits-282b-outline-phone' into feat/bits-283-type-picker
  PhilReinking
  committed
  35a9755
- docs: add changelog line for #274
  
  PhilReinking
  and
  claude
  committed
  8bef14d
- docs: add moving questions to the changelog line (#275)
  
  PhilReinking
  and
  claude
  committed
  c457846
- Merge remote-tracking branch 'origin/feat/bits-282b-outline-phone' into feat/bits-285-preview-panel
  
  PhilReinking
  and
  claude
  committed
  682709f
- docs: add the type picker to the changelog (#276)
  
  PhilReinking
  and
  claude
  committed
  e710ffd
- fix: fit Outline and Preview in the phone's count row
  
  PhilReinking
  and
  claude
  committed
  20e5418
- feat: open the editor's preview from the phone's form menu
  
  PhilReinking
  and
  claude
  committed
  7e08a5e
- Merge branch 'fix/bits-279-delete-dialogs' into stack/bits-274-phase-1
  PhilReinking
  committed
  876771a
- Merge branch 'fix/bits-280-save-status' into stack/bits-274-phase-1
  PhilReinking
  committed
  d758919
- fix: reload the preview after deleting a question, a choice or a rule
  
  PhilReinking
  and
  claude
  committed
  3ac5e2d
- Merge branch 'stack/bits-274-phase-1' into feat/bits-282-document-editor
  
  PhilReinking
  and
  claude
  committed
  0f2f881
- fix: reload the form when a page loads while an end screen save is on its way
  
  PhilReinking
  and
  claude
  committed
  c2b787b
- Merge branch 'feat/bits-282-document-editor' into feat/bits-282b-outline-phone
  PhilReinking
  committed
  68235f3
- Merge branch 'feat/bits-282b-outline-phone' into feat/bits-282c-keyboard-move
  PhilReinking
  committed
  794c36a
- feat: duplicate a question from its menu
  
  PhilReinking
  and
  claude
  committed
  30d05db
- Merge remote-tracking branch 'origin/feat/bits-282-document-editor' into feat/bits-284-logic-in-place
  PhilReinking
  committed
  fb62de1
- fix: ask in the app's dialog before removing a rule
  
  PhilReinking
  and
  claude
  committed
  4088f2f
- fix: load the form over the API, so a tab picked meanwhile stays
  
  PhilReinking
  and
  claude
  committed
  92c54b5
- fix: open the end screen card with the form loaded again after Back
  
  PhilReinking
  and
  claude
  committed
  2d1b81b
- fix: end a rule's edit when you leave the editor
  
  PhilReinking
  and
  claude
  committed
  c82d065
- Merge branch 'feat/bits-282c-keyboard-move' into feat/bits-283-type-picker
  
  PhilReinking
  and
  claude
  committed
  f9037f0
- docs: say that / picks the empty question's type
  
  PhilReinking
  and
  claude
  committed
  bfb6428
- feat: ask before deleting a question or group from its menu
  
  PhilReinking
  and
  claude
  committed
  96553ea
- docs: use the new answer type names and the picker steps
  
  PhilReinking
  and
  claude
  committed
  21be850
- feat: show the save status in the form's top bar
  
  PhilReinking
  and
  claude
  committed
  fef51c5
- fix: make every rule control 44 px below 1024, Cancel and Save rule together
  
  PhilReinking
  and
  claude
  committed
  da1e249
- fix: say "Always hidden" and drop the rule count from a question's meta
  
  PhilReinking
  and
  claude
  committed
  d35fa56
- feat: Add question at the end of the document adds at the end
  
  PhilReinking
  and
  claude
  committed
  2f9036d
- fix: an empty form doesn't say 0 questions
  
  PhilReinking
  and
  claude
  committed
  9b5a38d
- Merge remote-tracking branch 'origin/feat/bits-282-document-editor' into feat/bits-286-end-screen
  PhilReinking
  committed
  996c41f
- docs: describe the editor as one document with an outline
  
  PhilReinking
  and
  claude
  committed
  5b3693f
- fix: the type picker scrolls into view, and a phone keeps its keyboard down
  
  PhilReinking
  and
  claude
  committed
  53de514
- fix: the keyboard-picked answer type shows a blue ring
  
  PhilReinking
  and
  claude
  committed
  17d4bd1
- test: expect the save error text part a uses now
  
  PhilReinking
  and
  claude
  committed
  c00627e
- feat: mark where the open question jumps with a blue number pill
  
  PhilReinking
  and
  claude
  committed
  0dc5f5b
- fix: give the jump target chip a 44 px tap area below 1024
  
  PhilReinking
  and
  claude
  committed
  a8931ec
- fix: show the last of two overlapping saves in the preview
  
  PhilReinking
  and
  claude
  committed
  8af59b7
- fix: start the preview at the open question, without a jump
  
  PhilReinking
  and
  claude
  committed
  0514426
- fix: return focus to the form menu after its preview closes
  
  PhilReinking
  and
  claude
  committed
  4469fb7
- Merge remote-tracking branch 'origin/feat/bits-282b-outline-phone' into feat/bits-285-preview-panel
  PhilReinking
  committed
  a83d560
- Merge remote-tracking branch 'origin/feat/bits-282c-keyboard-move' into feat/bits-284-logic-in-place
  PhilReinking
  committed
  321841c
- fix: leave Retry to the red save bar on phones and tablets
  
  PhilReinking
  and
  claude
  committed
  fd0536e
- fix: line rules up with the question text on phones
  
  PhilReinking
  and
  claude
  committed
  5a39ee9
- fix: a click outside the / picker leaves the cursor where you clicked
  
  PhilReinking
  and
  claude
  committed
  3b5d677
- docs: answer type names in sentence case, as in the editor
  
  PhilReinking
  and
  claude
  committed
  17d3ccc
- docs: add duplicating a question to the changelog line (#277)
  
  PhilReinking
  and
  claude
  committed
  4c262ff
- Merge remote-tracking branch 'origin/feat/bits-282c-keyboard-move' into feat/bits-285-preview-panel
  PhilReinking
  committed
  12ed786
- fix: keep an end screen change when the page reloads or closes
  
  PhilReinking
  and
  claude
  committed
  ad113ff
- Merge remote-tracking branch 'origin/feat/bits-282c-keyboard-move' into feat/bits-286-end-screen
  PhilReinking
  committed
  bcb79eb
- fix: a click elsewhere leaves the cursor there, also for the end picker
  
  PhilReinking
  and
  claude
  committed
  e323b14
- fix: start the preview at once when no question is open
  
  PhilReinking
  and
  claude
  committed
  f0e5ccc
- fix: say why the preview can't show a hidden question
  
  PhilReinking
  and
  claude
  committed
  072884f
- docs: say the other pages' Preview saves no answers either
  
  PhilReinking
  and
  claude
  committed
  a1f2a83
- Merge branch 'feat/bits-284-logic-in-place' into stack/bits-274-phase-2
  PhilReinking
  committed
  089b848
- Merge branch 'feat/bits-282d-wire-phase-1' into stack/bits-274-phase-2
  PhilReinking
  committed
  5297939
- fix: keep the save status width so the top bar doesn't move on each save
  
  PhilReinking
  and
  claude
  committed
  76aee72
- feat: name the save status in a tooltip when only its icon shows
  
  PhilReinking
  and
  claude
  committed
  936115b
- Merge branch 'feat/bits-283-type-picker' into stack/bits-274-phase-2
  PhilReinking
  committed
  0cb167f
- fix: put the cursor at the end of a question's text when it opens
  
  PhilReinking
  and
  claude
  committed
  7bef7ab
- Merge branch 'feat/bits-286-end-screen' into stack/bits-274-phase-2
  PhilReinking
  committed
  6969fa0
- fix: name a question by its number in the delete dialog
  
  PhilReinking
  and
  claude
  committed
  70e2ae5
- fix: say a question couldn't be duplicated when the copy fails
  
  PhilReinking
  and
  claude
  committed
  c3a8181
- Merge branch 'feat/bits-285-preview-panel' into stack/bits-274-phase-2
  PhilReinking
  committed
  d038b7d
- fix: the end screen test finds the type picker on an empty form after merging #276 and #271
  
  PhilReinking
  and
  claude
  committed
  66ffab3
- fix: the preview reloads after a saved rule after merging #274 and #273
  
  PhilReinking
  and
  claude
  committed
  637094a
- fix: an empty form keeps the Preview button on a phone after merging #276 and #273
  
  PhilReinking
  and
  claude
  committed
  32f854b
- fix: say a question couldn't be deleted when the delete fails
  
  PhilReinking
  and
  claude
  committed
  e859a30
- fix: give the open end card the question card's phone sizes and one focus bar
  
  PhilReinking
  and
  claude
  committed
  ef472fa
- fix: name the end screen in its save error
  
  PhilReinking
  and
  claude
  committed
  aa1c1f4
- Merge branch 'feat/bits-282d-wire-phase-1' into stack/bits-274-phase-2
  PhilReinking
  committed
  4b54d73
- fix: keep the end screen's hidden label inside the document
  
  PhilReinking
  and
  claude
  committed
  4b57119
- fix: use plain words in the answer field, rating, date and file settings
  
  PhilReinking
  and
  claude
  committed
  a3a6f5b
- fix: say choice and consent in the choice and consent settings
  
  PhilReinking
  and
  claude
  committed
  3d5ca41
- fix: name the settings by answer type and say where the short name shows
  
  PhilReinking
  and
  claude
  committed
  0e9e6a9
- fix: show every switch in the editor as on or off
  
  PhilReinking
  and
  claude
  committed
  0a5b7a1
- fix: use plain words in the text editor's toolbar, counter and prompts
  
  PhilReinking
  and
  claude
  committed
  3170da7
- fix: name new rules Rule 1 and give the group name an example
  
  PhilReinking
  and
  claude
  committed
  3e1e426
- Merge branch 'feat/bits-286-end-screen' into stack/bits-274-phase-2
  PhilReinking
  committed
  3c9e495
- docs: use the editor's new setting names in the help pages
  
  PhilReinking
  and
  claude
  committed
  50015c0
- Merge remote-tracking branch 'origin/stack/bits-274-phase-2' into feat/bits-287-wording
  PhilReinking
  committed
  26b6454
- docs: add the editor wording change to the changelog
  
  PhilReinking
  and
  claude
  committed
  f77efdb
- fix: don't say emails use the short name
  
  PhilReinking
  and
  claude
  committed
  b698273
- fix: tie "None ticked: all types allowed." to the file type boxes
  
  PhilReinking
  and
  claude
  committed
  4ee7e54
- fix: use plain words for the text editor's default placeholder
  
  PhilReinking
  and
  claude
  committed
  2e16cb7
- fix: drop the settings heading where a type has no settings of its own
  
  PhilReinking
  and
  claude
  committed
  84d0bd9
- fix: say "a deleted question" in a rule's sentence
  
  PhilReinking
  and
  claude
  committed
  4798dbf
- fix: use short example placeholders in the long text and number settings
  
  PhilReinking
  and
  claude
  committed
  0af912b
- fix: show an example, not "No limit", as the max characters placeholder
  
  PhilReinking
  and
  claude
  committed
  b294005
- fix: start the Consent and Text only settings at the panel top
  
  PhilReinking
  and
  claude
  committed
  c6354e6
- fix: show the end screen in the preview while its block is open
  
  PhilReinking
  and
  claude
  committed
  003acf3
- fix: call the completion page "End screen" in Settings too
  
  PhilReinking
  and
  claude
  committed
  6f6e0b6
- docs: add changelog line for #280
  
  PhilReinking
  and
  claude
  committed
  61b8846
- fix: open the end screen's button in a new tab in the preview
  
  PhilReinking
  and
  claude
  committed
  474f4e7
- docs: say "End screen" in the #271 changelog line, add the button to #280's
  
  PhilReinking
  and
  claude
  committed
  dd6cfb8
- feat: draw a line where each question starts and give the open one room
  
  PhilReinking
  and
  claude
  committed
  d4fc15d
- feat: make the question number the anchor under its line
  
  PhilReinking
  and
  claude
  committed
  61ac0d9
- feat: lift the open question and end screen card with a bigger shadow
  
  PhilReinking
  and
  claude
  committed
  205ca06
- feat: give the document a 16 px side margin on phones and keep a group's name whole
  
  PhilReinking
  and
  claude
  committed
  d28d4b8
- fix: keep the cursor in the editor when the preview moves
  
  PhilReinking
  and
  claude
  committed
  be5e3e2
- docs: add changelog line for #281
  
  PhilReinking
  and
  claude
  committed
  d6949dd
- fix: say "No end screen" only for a web link, as the form redirects
  
  PhilReinking
  and
  claude
  committed
  bb54d3f
- docs: add the preview focus fix to #280's changelog line
  
  PhilReinking
  and
  claude
  committed
  83ec4a3
- Merge remote-tracking branch 'origin/fix/bits-285-preview-end-screen' into feat/bits-295-question-lines
  PhilReinking
  committed
  c4f3ac1
- fix: start the end screen with a line and give it room when open
  
  PhilReinking
  and
  claude
  committed
  a945952
- fix: wrap a group's Add rule and menu together, on the right
  
  PhilReinking
  and
  claude
  committed
  b8154f7
- fix: let the preview move the cursor on once the owner clicks into it
  
  PhilReinking
  and
  claude
  committed
  aadadae
- fix: close the preview panel on Esc inside the preview
  
  PhilReinking
  and
  claude
  committed
  3ab955b
- docs: add Esc in the preview to #280's changelog line
  
  PhilReinking
  and
  claude
  committed
  1bb9bf6
- Merge remote-tracking branch 'origin/fix/bits-285-preview-end-screen' into feat/bits-295-question-lines
  PhilReinking
  committed
  ceadf5e
- Merge remote-tracking branch 'origin/main' into land/bits-274-editor
  PhilReinking
  committed
  cdb443c
- Merge remote-tracking branch 'origin/main' into land/bits-274-editor
  
  PhilReinking
  and
  claude
  committed
  48d1d0b

Commits

Commits on Oct 12, 2026

Commits on Oct 13, 2026