Skip to content

Mark where each question starts and give the open question room - #281

Closed
PhilReinking wants to merge 9 commits into
fix/bits-285-preview-end-screenfrom
feat/bits-295-question-lines
Closed

PhilReinking wants to merge 9 commits into
fix/bits-285-preview-end-screenfrom
feat/bits-295-question-lines

Conversation

@PhilReinking

@PhilReinking PhilReinking commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

The editor now draws a thin line where each question starts, makes the number the anchor under it, and gives the open question 24 px above and below. On phones the side margin grows to 16 px.

Fixes BITS-295.

  • The space and line sit on each block's wrapper, not the row, so the margin's rule line still lines up.
  • No line on the first block of a list or next to a group's frame.
  • The end screen starts with a line too, and gets 24 px above and below when open.
  • On phones down to 360 px a group's name stays whole; Add rule and its menu wrap below it together, on the right.
  • The open question and end screen cards get a bigger shadow.

Changed from the spec: an open group keeps 8 px. Only an open question gets 24 px, so a group doesn't jump when you click Add rule.

Stacked on #280: no CI here, all checks ran locally.

Tested: Vitest (the new tests fail without the change), lint, vue-tsc, build. By hand at 1440, 1024, 390 and 360 on a 34-question form. Design check passed.

🤖 Generated with Claude Code

PhilReinking and others added 8 commits October 13, 2026 11:55
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…p's name whole

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… into feat/bits-295-question-lines

# Conflicts:
#	CHANGELOG.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@PhilReinking PhilReinking left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK at b8154f7. No CI (stacked), local runs: Vitest 500, lint, vue-tsc, build. The 5 new tests fail without their change.

Checked at 1440, 1024, 390 and 360: 28 lines, none on a first block, a group or a question after a group. The rule line meets both numbers exactly, the add line sits on the divider, and the open question and end screen get 24 px. At 360 Add rule and the menu wrap together.

… into feat/bits-295-question-lines

# Conflicts:
#	CHANGELOG.md
@PhilReinking

Copy link
Copy Markdown
Contributor Author

Landed in main with #282 (the editor rebuild as one PR); this PR's commits are part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant