Repository navigation
Mark where each question starts and give the open question room - #281
Closed
PhilReinking wants to merge 9 commits into
Closed
PhilReinking wants to merge 9 commits into
PhilReinking wants to merge 9 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…p's name whole Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… into feat/bits-295-question-lines # Conflicts: # CHANGELOG.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 13, 2026
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at b8154f7. No CI (stacked), local runs: Vitest 500, lint, vue-tsc, build. The 5 new tests fail without their change.
Checked at 1440, 1024, 390 and 360: 28 lines, none on a first block, a group or a question after a group. The rule line meets both numbers exactly, the add line sits on the divider, and the open question and end screen get 24 px. At 360 Add rule and the menu wrap together.
… into feat/bits-295-question-lines # Conflicts: # CHANGELOG.md
Contributor
Author
|
Landed in main with #282 (the editor rebuild as one PR); this PR's commits are part of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor now draws a thin line where each question starts, makes the number the anchor under it, and gives the open question 24 px above and below. On phones the side margin grows to 16 px.
Fixes BITS-295.
Changed from the spec: an open group keeps 8 px. Only an open question gets 24 px, so a group doesn't jump when you click Add rule.
Stacked on #280: no CI here, all checks ran locally.
Tested: Vitest (the new tests fail without the change), lint, vue-tsc, build. By hand at 1440, 1024, 390 and 360 on a 34-question form. Design check passed.
🤖 Generated with Claude Code