Repository navigation
Use the review's words across the editor - #279
PhilReinking wants to merge 17 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t/bits-287-wording
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
left a comment
There was a problem hiding this comment.
OK at f77efdb, one should and one nit inline. No CI (stacked), local runs: Vitest 481, lint, vue-tsc, build.
The 13 new or changed tests fail on 3c9e495. Applied rows match the table and Philipp's calls, and the old words are gone from the settings and the docs. The CSV export does use question IDs. All 15 answer types read right at 1440, the 390 sheets don't overflow. Dropping the word count and Yes/No changes no behavior.
| <p :id="`${id}-identifier-help`" class="mb-1 text-xs text-grey-600"> | ||
| This name is used when submitting your form through webhooks and in the | ||
| export. | ||
| Used in prefill links, webhooks, emails and the submissions table. |
There was a problem hiding this comment.
Should: the submission email doesn't use the short name. form-submitted.blade.php shows the question ID, the question text and the answer. Prefill links, webhooks (name in each response) and the submissions table (SubmissionsTable.vue:105) do use it. The document tests pass with this text.
| Used in prefill links, webhooks, emails and the submissions table. | |
| Used in prefill links, webhooks and the submissions table. |
| :label="fileType.label" | ||
| /> | ||
| </div> | ||
| <p class="mt-1 text-xs text-grey-600">None ticked: all types allowed.</p> |
There was a problem hiding this comment.
Nit: this line comes after the boxes and isn't tied to them, so someone who tabs through the boxes with a screen reader doesn't hear it. The markup allows it: id="file-types" on the D9Label (it then renders id="file-types-label"), role="group" aria-labelledby="file-types-label" aria-describedby="file-types-help" on the wrapper, and id="file-types-help" here. Not run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
left a comment
There was a problem hiding this comment.
OK at 2e16cb7, both earlier points fixed. No CI (stacked), local runs: Vitest 481, lint, vue-tsc, build.
In the browser the file types are one group named "File types" and described by "None ticked: all types allowed." The short name help no longer names emails. The end screen text shows "Type your text…", questions keep their own placeholder.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
left a comment
There was a problem hiding this comment.
OK at 0af912b, one should inline. No CI (stacked), local runs: Vitest 481, lint, vue-tsc, build. The 3 changed tests fail on 2e16cb7.
Consent and Text only keep the panel named "Settings" for screen readers. The rule chip reads "If a deleted question is …". Nit: the hidden heading still takes space-y-6, so those panels start 40 px above Short name, not 16 px.
| <D9Input | ||
| id="textarea-max-chars" | ||
| placeholder="The maximum number of characters" | ||
| placeholder="No limit" |
There was a problem hiding this comment.
Should: an empty field saves max_chars: null, and the public form then has no limit. But opening the question again shows 500 (?? 500 on line 64) and saves 500 back, so "No limit" lasts only until the next open. Tried on the test server, value put back after. The reset is old; this text just invites people to try it. Factory tests pass with this.
| placeholder="No limit" | |
| placeholder="e.g. 500" |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
left a comment
There was a problem hiding this comment.
OK at c6354e6, both points from 0af912b fixed. No CI (stacked), local runs: Vitest 481, lint, vue-tsc, build. The 2 changed heading tests fail on 0af912b.
Chrome's accessibility tree still names the Consent and Text only panels "Settings" through the hidden heading. Those panels now start 16 px down. Short text, Long text, Single choice, Rating, Date and File upload are unchanged.
|
Landed in main with #282 (the editor rebuild as one PR); this PR's commits are part of it. |
The editor's answer settings, choices, consents and text toolbar now use the review's wording table: plain words, sentence case, and settings headings named by answer type. So do the help pages. The table below marks rows earlier PRs changed.
Fixes BITS-287
useContentLength.EmptyState's description is optional now.Tested: Vitest, lint, vue-tsc and build green locally (stacked, so no CI). By hand at 1440 and 390: settings of all 15 answer types, type picker, rules, top bar menus.
Not tested: with a screen reader.
Screenshots: on BITS-287.
Known gap: help texts under
D9Labelaren't tied to their field and are grey-400 on grey-50 (2.4:1). Both come fromD9Labelitself.Not in this PR: consent "Label" and "Message" placeholders, yes/no switches on the Privacy and Completion pages.
Wording table: every row
🤖 Generated with Claude Code