Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native bigint operands are accepted by the public typings, but arithmetic, comparison and bitwise methods call the internal fromValue, which does not handle bigint. These inputs are converted to zero-valued low/high words.
Reproductions on current main / long@5.3.2:
Move bigint dispatch into the shared internal fromValue and remove the redundant public wrapper. Long.fromValue(bigint) remains supported, and methods now use the same conversion. The bigint check remains first in the dispatch path.
Add regression coverage against native BigInt for arithmetic, bitwise operations, comparisons, division/remainder by zero and conversion of values outside 64 bits.
Validation (Node 22.13.0):
npm run buildnpm test(unit tests, Closure library tests and all four TypeScript configurations)npm run lint