Skip to content

Allow attaching issues to closed milestones #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbutenhof merged 1 commit into from
Oct 12, 2026
Merged

Allow attaching issues to closed milestones #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 175 additions & 61 deletions frontend/src/components/IssueCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import {
addLabel,
removeLabel,
createLabel,
fetchMilestones,
setIssueMilestone,
removeIssueMilestone,
fetchIssueReactions,
Expand Down Expand Up @@ -150,6 +151,11 @@ const IssueCard = ({
const [isCreatingLabel, setIsCreatingLabel] = useState(false);
const [currentMilestone, setCurrentMilestone] = useState(issue.milestone);
const [isMilestoneMenuOpen, setIsMilestoneMenuOpen] = useState(false);
const [milestoneTab, setMilestoneTab] = useState(0);
const [closedMilestones, setClosedMilestones] = useState([]);
const [closedMilestonesLoaded, setClosedMilestonesLoaded] = useState(false);
const [closedMilestonesLoading, setClosedMilestonesLoading] = useState(false);
const [closedMilestonesError, setClosedMilestonesError] = useState(null);
const milestoneMenuRef = useRef(null);
const milestoneToggleRef = useRef(null);
const menuRef = useRef(null);
Expand Down Expand Up @@ -825,9 +831,10 @@ const IssueCard = ({
} else {
// Set milestone
await setIssueMilestone(issue.number, milestoneNumber);
const newMilestone = milestonesCache.data.find(
(m) => m.number === milestoneNumber
);
const newMilestone = [
...milestonesCache.data,
...closedMilestones,
].find((m) => m.number === milestoneNumber);
if (newMilestone) {
setCurrentMilestone(newMilestone);
}
Expand All @@ -845,6 +852,32 @@ const IssueCard = ({
}
};

// Assisted-by: openai-code-assist
const loadClosedMilestones = () => {
if (closedMilestonesLoaded || closedMilestonesLoading) return;

setClosedMilestonesLoading(true);
setClosedMilestonesError(null);
fetchMilestones('closed')
.then((data) => {
setClosedMilestones(data);
setClosedMilestonesLoaded(true);
setClosedMilestonesLoading(false);
})
.catch((err) => {
setClosedMilestonesError(err.message);
setClosedMilestonesLoading(false);
});
};

const handleMilestoneTabSelect = (_event, key) => {
const nextTab = Number(key);
setMilestoneTab(nextTab);
if (nextTab === 1) {
loadClosedMilestones();
}
};

const isLabelSelected = (labelName) => {
return currentLabels.some((label) => label.name === labelName);
};
Expand Down Expand Up @@ -1903,7 +1936,12 @@ const IssueCard = ({
>
<Button
variant={currentMilestone ? 'primary' : 'secondary'}
onClick={() => setIsMilestoneMenuOpen(!isMilestoneMenuOpen)}
onClick={() => {
setIsMilestoneMenuOpen(!isMilestoneMenuOpen);
if (!isMilestoneMenuOpen) {
setMilestoneTab(0);
}
}}
style={{
padding: '0.25rem 0.75rem',
fontSize: '0.75rem',
Expand All @@ -1930,64 +1968,140 @@ const IssueCard = ({
overflowY: 'auto',
}}
>
<div
style={{
padding: '0.5rem',
cursor: 'pointer',
borderBottom: '1px solid #d2d2d2',
backgroundColor:
currentMilestone === null ? '#f0f0f0' : 'transparent',
}}
onClick={() => {
handleMilestoneChange(null);
setIsMilestoneMenuOpen(false);
}}
onMouseEnter={(e) => {
if (currentMilestone !== null) {
e.currentTarget.style.backgroundColor = '#f0f0f0';
}
}}
onMouseLeave={(e) => {
if (currentMilestone !== null) {
e.currentTarget.style.backgroundColor = 'transparent';
}
}}
<Tabs
activeKey={milestoneTab}
onSelect={handleMilestoneTabSelect}
aria-label={`Milestone state for issue #${issue.number}`}
>
<span style={{ fontSize: '0.875rem', fontStyle: 'italic' }}>
No Milestone
</span>
</div>
{milestonesCache.data.map((milestone) => (
<div
key={milestone.number}
style={{
padding: '0.5rem',
cursor: 'pointer',
backgroundColor:
currentMilestone?.number === milestone.number
? '#f0f0f0'
: 'transparent',
}}
onClick={() => {
handleMilestoneChange(milestone.number);
setIsMilestoneMenuOpen(false);
}}
onMouseEnter={(e) => {
if (currentMilestone?.number !== milestone.number) {
e.currentTarget.style.backgroundColor = '#f0f0f0';
}
}}
onMouseLeave={(e) => {
if (currentMilestone?.number !== milestone.number) {
e.currentTarget.style.backgroundColor = 'transparent';
}
}}
>
<span style={{ fontSize: '0.875rem' }}>
{milestone.title}
</span>
</div>
))}
<Tab eventKey={0} title={<TabTitleText>Open</TabTitleText>}>
<div>
<div
style={{
padding: '0.5rem',
cursor: 'pointer',
borderBottom: '1px solid #d2d2d2',
backgroundColor:
currentMilestone === null
? '#f0f0f0'
: 'transparent',
}}
onClick={() => {
handleMilestoneChange(null);
setIsMilestoneMenuOpen(false);
}}
onMouseEnter={(e) => {
if (currentMilestone !== null) {
e.currentTarget.style.backgroundColor = '#f0f0f0';
}
}}
onMouseLeave={(e) => {
if (currentMilestone !== null) {
e.currentTarget.style.backgroundColor =
'transparent';
}
}}
>
<span
style={{ fontSize: '0.875rem', fontStyle: 'italic' }}
>
No Milestone
</span>
</div>
{milestonesCache.data
.filter((milestone) => milestone.number !== 0)
.map((milestone) => (
<div
key={milestone.number}
style={{
padding: '0.5rem',
cursor: 'pointer',
backgroundColor:
currentMilestone?.number === milestone.number
? '#f0f0f0'
: 'transparent',
}}
onClick={() => {
handleMilestoneChange(milestone.number);
setIsMilestoneMenuOpen(false);
}}
onMouseEnter={(e) => {
if (
currentMilestone?.number !== milestone.number
) {
e.currentTarget.style.backgroundColor =
'#f0f0f0';
}
}}
onMouseLeave={(e) => {
if (
currentMilestone?.number !== milestone.number
) {
e.currentTarget.style.backgroundColor =
'transparent';
}
}}
>
<span style={{ fontSize: '0.875rem' }}>
{milestone.title}
</span>
</div>
))}
</div>
</Tab>
<Tab eventKey={1} title={<TabTitleText>Closed</TabTitleText>}>
{closedMilestonesLoading && (
<div style={{ padding: '1rem', textAlign: 'center' }}>
<Spinner
size="md"
aria-label="Loading closed milestones"
/>
</div>
)}
{closedMilestonesError && (
<Alert
variant="danger"
isInline
title="Error loading closed milestones"
>
{closedMilestonesError}
</Alert>
)}
{!closedMilestonesLoading &&
!closedMilestonesError &&
closedMilestones.map((milestone) => (
<div
key={milestone.number}
style={{
padding: '0.5rem',
cursor: 'pointer',
backgroundColor:
currentMilestone?.number === milestone.number
? '#f0f0f0'
: 'transparent',
}}
onClick={() => {
handleMilestoneChange(milestone.number);
setIsMilestoneMenuOpen(false);
}}
onMouseEnter={(e) => {
if (currentMilestone?.number !== milestone.number) {
e.currentTarget.style.backgroundColor = '#f0f0f0';
}
}}
onMouseLeave={(e) => {
if (currentMilestone?.number !== milestone.number) {
e.currentTarget.style.backgroundColor =
'transparent';
}
}}
>
<span style={{ fontSize: '0.875rem' }}>
{milestone.title}
</span>
</div>
))}
</Tab>
</Tabs>
</div>
)}
</div>
Expand Down
49 changes: 49 additions & 0 deletions frontend/src/components/IssueCard.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,55 @@ describe('IssueCard', () => {
});
});

it('loads closed milestones in a separate tab and can assign one', async () => {
const user = userEvent.setup();
const onMilestoneChange = vi.fn();
const closedMilestone = {
number: 11,
title: 'Completed release',
state: 'closed',
};
milestonesCache.data = [{ number: 10, title: 'Next release' }];
api.fetchMilestones.mockResolvedValue([closedMilestone]);
api.setIssueMilestone.mockResolvedValue({});

await act(async () => {
render(
<table>
<tbody>
<IssueCard
issue={mockIssue}
onMilestoneChange={onMilestoneChange}
/>
</tbody>
</table>
);
});

await user.click(screen.getByRole('button', { name: 'No Milestone' }));
expect(screen.getByRole('tab', { name: 'Open' })).toBeInTheDocument();
expect(screen.getByRole('tab', { name: 'Closed' })).toBeInTheDocument();

await user.click(screen.getByRole('tab', { name: 'Closed' }));

await waitFor(() => {
expect(api.fetchMilestones).toHaveBeenCalledWith('closed');
expect(screen.getByText('Completed release')).toBeInTheDocument();
});
await user.click(screen.getByText('Completed release'));

await waitFor(() => {
expect(api.setIssueMilestone).toHaveBeenCalledWith(459, 11);
expect(onMilestoneChange).toHaveBeenCalledWith({
fromMilestoneNumber: null,
toMilestoneNumber: 11,
});
expect(
screen.getByRole('button', { name: 'Completed release' })
).toBeInTheDocument();
});
});

it('calls onMilestoneChange with to null when milestone is removed', async () => {
const user = userEvent.setup();
const onMilestoneChange = vi.fn();
Expand Down
Loading