Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A table named
products 1is valid in SQLite, but it makes\llmfail withnear "1": syntax errorwhile preparing sample rows. The query uses the table name without quoting it.This quotes table and view names and escapes any double quotes inside them. The new tests use real SQLite databases with spaces, reserved words, quotes, and dots in object names. Only the external LLM command is mocked.
Related to #253. This reproduces the same error, although I couldn't check the reporter's database to confirm its cause.
The suite passes on Python 3.10 and 3.13, including runs with and without SQLean: 238 passed, with the same skips and expected/unexpected failures as main.
tox -e stylepasses with the Ruff version pinned in CI. Type checking passes for the changed files; the full check still reports the same five existing diagnostics as main.Codex helped with the patch and tests.
Checklist
CHANGELOG.mdfile.