Repository navigation
ci: Run build and test on every pull request - #31
Merged
Merged
Conversation
Tests ran only on push, behind a paths filter in some repos, so a fork's pull request got no check and a change outside the filter was never tested. Call the shared ci-basic workflow on pull_request so every PR reports "ci / Build and test", ready to be a required check. The old push-only test workflow is removed; ci-basic runs the same go test plus a build, so keeping both would test every push twice.
andrewb3000
previously approved these changes
Nov 2, 2026
The removed push-only test workflow ran go mod verify, which ci-basic doesn't. Run it in the CI check so a tampered or mismatched module still fails the build.
andrewb3000
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests here merged untested: tests ran only on push (often behind a
paths:filter), so a fork's PR got no check. Every PR now reportsci / Build and test, which lets the org require it. Part of datum-cloud/infra#8399.Technical detail
Adds
.github/workflows/ci.yamlcallingdatum-cloud/actionsci-basicat v1.26.0 onpull_request(nopaths:/branches:filter) and on push to main. Single non-matrix jobci, so the context staysci / Build and test.The push-only test workflow is removed;
ci-basicrunsgo test ./...andgo build ./...too, so keeping both would test every push twice. It also rango mod verify, which is no longer run.Fixes #30