Skip to content

ci: Add the required CI caller - #325

Merged
ecv merged 1 commit into
mainfrom
ci/required-ci-check
Nov 2, 2026
Merged

ecv merged 1 commit into
mainfrom
ci/required-ci-check

Conversation

@ecv

@ecv ecv commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Pull requests here can merge with a red or missing build. This adds the shared ci / Build and test check, so build and test failures show on every pull request and infra can make the check required.

Runs go build ./... and go test ./... (Go version from go.mod). No test uses envtest. The Dockerfile build is skipped; Build and Test already builds and publishes the image on pull requests. The existing lint and test workflows are left alone.

Fixes #324

Pull requests could merge with a red or missing build. Add a caller for the shared ci-basic workflow so every pull request reports `ci / Build and test`, which infra will require org-wide.

Build and unit-test the Go module on every pull request.
@ecv
ecv requested a review from andrewb3000 November 2, 2026 21:35
@ecv
ecv requested a review from a team as a code owner November 2, 2026 21:35

@kevwilliams kevwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the job set up Go 1.27.3 from go.mod and ran the controller, resourcemanager and features tests, with the duplicate Docker build skipped.

@ecv
ecv merged commit 71161af into main Nov 2, 2026
10 checks passed
@ecv
ecv deleted the ci/required-ci-check branch November 2, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require a passing CI check to merge

2 participants