Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #25 (wired LOG_LEVEL). With DEBUG logging actually working
now, confirmed the ckan:resource-update-stress 404 still shows up only
as the generic wrapped message ("Not Found") at the error-handler layer
— because
_read_schema'sexcept NotFound: return Nonenever capturedor logged the original exception at all. There was nothing more to see
at any log level, by design of this specific except clause, not because
logging was misconfigured.
What changed
datastore/infrastructure/engines/bigquery/backend.py:_read_schema'sNotFoundhandler now logs the resource_id, the exact table ref queried,and the raw exception (
%son theNotFoundinstance includes Google'sresponse body) at DEBUG before returning
None. Still returnsNonefor the caller exactly as before — behavior unchanged, only adds
visibility.
What was verified
pytest tests/ -k "not integration"):494 passed, same as baseline, same two pre-existing unrelated
failures in
tests/test_datastore_dump.pyexcluded (confirmedpre-existing on
mainin Wire LOG_LEVEL config into logging.basicConfig #25).tests/engines/bigquery/specifically: 94 passed.Context
Investigating a persistent
datastore_search404 for resources thathave real, verified data in BigQuery —
datastore_authorizesucceeds,IAM checks out with the same read-only service account, and a fresh
BigQuery client can query the same table instantly, but the live service
consistently 404s.
google.api_core.exceptions.NotFoundfromtables.getwas the confirmed source of the 404, but its detail wasnever captured anywhere in the request path. This PR closes that gap —
next occurrence of this bug should show the real Google API response.
Deployment
Needs a rebuild + redeploy of the datastore image, same as #25.