Repository navigation
build(deps): require qsv-client>=0.2.0 - #348
Merged
Merged
Conversation
qsv-client 0.2.0 bounds a timeout even when a process qsv started (e.g. one spawned by describegpt) leaves the process group and keeps the output pipes open; with >=0.1.0, an environment that already has 0.1.0 installed keeps it on `pip install -r requirements.txt`. No DP+ code changes are needed: QSVCommand only uses Qsv(binary=, timeout=), run(check=False, text=) and error_from_run, all unchanged. test_a_failed_search_raises_job_error patched pathlib.Path.absolute process-wide to point the PII regex file at a missing path. qsv-client 0.2.0 resolves the qsv binary with Path.absolute(), so the patch also turned the binary into the missing regex file (FileNotFoundError instead of JobError). It now moves pii_screening.__file__ into tmp_path instead, which makes only the default regex path missing. Passes on 0.1.0 and 0.2.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises the floor to
qsv-client>=0.2.0(release notes). With>=0.1.0, a fresh install already gets 0.2.0, but an environment that has 0.1.0 installed keeps it onpip install -r requirements.txt.The fix that matters for DP+: a qsv timeout is bounded again even when a process qsv started (for example one spawned by
describegptin the AI suggestions stage) leaves the process group and keeps the output pipes open. Before, the job waited for that process to exit. The 0.2.0 Windows support doesn't affect DP+.No DP+ code changes.
QSVCommandonly usesQsv(binary=, timeout=),run(check=False, text=)anderror_from_run, none of which changed. The tests that mockqsv_client._process.run_sync/RawResultstill work, since both keep the same signatures.One test fix
test_a_failed_search_raises_job_errorpatchedpathlib.Path.absoluteprocess-wide (pii_screening.Pathispathlib.Path) to point the PII regex file at a missing path. qsv-client 0.2.0 resolves the qsv binary withPath.absolute(), so the patch also turned the qsv binary into the missing regex file. The test then gotFileNotFoundErrorinstead ofJobError. It now movespii_screening.__file__intotmp_path, which makes only the default regex path missing. It passes on both 0.1.0 and 0.2.0.Test plan
Run in a scratch environment (CKAN 2.11.6, Python 3.11, qsv 24.0.0), with CKAN's pytest plugins disabled because these unit tests don't need a CKAN
.ini:tests/test_qsv_command_client.pyandtests/test_ai_suggestions.py: 57 passed on qsv-client 0.2.0tests/test_pii_screening_search.py: 21 passed on both 0.1.0 and 0.2.0tests/ --ignore=tests/integration): the same set of failures on 0.1.0 and 0.2.0. All of them need the Prefect/CKAN services this environment lacks, and none are new.🤖 Generated with Claude Code