Repository navigation
ci: run the JS (Vitest) suite in the Unit Tests workflow - #347
Merged
Merged
Conversation
The 12 tests under tests/js/ pin the polling contract between scheming-ai-suggestions.js and the Python pipeline, but no workflow ran them, so Dependabot's npm bumps (vitest, jsdom, jquery) merged unchecked. Adds a js-tests job (Node 22, npm ci + npm test) alongside the Python unit suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The 12 Vitest tests under
tests/js/pin the polling contract betweenscheming-ai-suggestions.jsand the Python pipeline, but no workflow ran them. Dependabot's npm bumps (#333, #339) were only checked because someone rannpm testby hand.What
A
js-testsjob intest.yml(the Unit Tests workflow), running alongside the Python unit suite on the same triggers:actions/setup-node@v4with npm cachingnpm ci, thennpm testVerification
npm ci && npm testlocally: 12/12 pass.actionlintis clean.🤖 Generated with Claude Code