Skip to content

fix(homebrew): avoid redundant formula version - #35

Merged
jinroh merged 1 commit into
mainfrom
fix/homebrew-version-inference
Oct 16, 2026
Merged

jinroh merged 1 commit into
mainfrom
fix/homebrew-version-inference

Conversation

@jinroh

@jinroh jinroh commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Homebrew audit rejects an explicit version when it can infer the same version from the release URL. Read the update offer version from those URLs instead, and update the demo and formula expectations.

How to test it

Same as #32, with scripts/try-update.sh

Checklist

  • I have reviewed the contributing guidelines (CONTRIBUTING.md in the repository root).
  • I have added tests or explained why they are not needed.
  • I have updated the documentation if needed.

Homebrew audit rejects an explicit version when it can infer the same version from the release URL. Read the update offer version from those URLs instead, and update the demo and formula expectations.
@jinroh
jinroh requested a review from a team as a code owner October 16, 2026 16:03

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The generated formula drops the version marker required by the published v0.0.8 updater. Those installations will silently stop discovering newer releases, including the release introducing URL-based parsing, until users upgrade manually.

Open Bits AI session

🤖 Bits Code Review · Commit c917a5d

Comment thread .github/homebrew/bits.rb.erb
@jinroh
jinroh merged commit 2597ab9 into main Oct 16, 2026
14 checks passed
@jinroh
jinroh deleted the fix/homebrew-version-inference branch October 16, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants