Repository navigation
CensusACS5YearSurvey_SubjectTables_S2201 | Data refresh - #2266
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ACS S2201 data processing pipeline to support processing local ZIP files as an alternative to downloading them, integrates a shared geo ID resolution helper, and improves CSV parsing robustness. Feedback on these changes highlights a hardcoded API key and incorrect table ID in the README, a directory mismatch in the execution instructions, a typo in the output filename, and a lack of exception handling and status checks for the network request and ZIP extraction in process.py.
SandeepTuniki
left a comment
SandeepTuniki
left a comment
There was a problem hiding this comment.
Thank you for the update! The switch to the shared convert_to_place_dcid helper (fixing the missing dcid: prefix on school district GeoIDs), the deterministic sorting of multi-year ZIP entries, and the 2010–2024 data refresh all look good.
However, a few things around HTTP error handling, CSV/ZIP filtering, unit test coverage for the new code paths, and README.md paths need some changes. I've left inline comments with the details.
SandeepTuniki
left a comment
SandeepTuniki
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments! Can you please fix the failing unit tests? I've left an inline comment with the fix.
CensusACS5YearSurvey_SubjectTables_S2201- 2024 observation year is fully ingested; all 15 historical years (2010 -2024) are present.