Skip to content

fix(search-bar): make the placeholder readable in dark mode - #64

Open
ross-dash wants to merge 2 commits into
masterfrom
fix/searchbar-placeholder-dark
Open

fix(search-bar): make the placeholder readable in dark mode#64
ross-dash wants to merge 2 commits into
masterfrom
fix/searchbar-placeholder-dark

Conversation

@ross-dash

@ross-dash ross-dash commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Fixes #54. The SearchBar prompt used Color.dash.black1000Alpha30, which has no dark variant, so in dark mode the placeholder was black on near-black.

What was done?

The prompt uses Color.dash.searchPlaceholder: the same black at 30% in light mode (identical colour, so the light reference does not change), white at 50% in dark mode. The dark snapshot reference, which had recorded the bug, is re-recorded from CI.

How Has This Been Tested?

  • swift build, .github/scripts/conventions.sh.
  • Snapshot job failed on the old dark reference as expected; the new one was fetched with .github/scripts/fetch-snapshots.sh (run 43237599092).

Before / After

Snapshot references (SearchBarSnapshotTests/testPlaceholderAndText). Light is unchanged (same colour); dark is re-recorded in 306b391.

Before After
Light
Dark
  • No visual change (refactor, tests, docs). Say why in "What was done?".

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

🤖 Generated with Claude Code

@optimisticcreator @claude
fix(search-bar): make the placeholder readable in dark mode
53ffe6b 
The prompt used black1000Alpha30, which has no dark variant, so on a dark
background the placeholder was black on near-black. It now uses the
searchPlaceholder token: the same black at 30% in light mode, white at 50%
in dark mode.

Fixes #54

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@optimisticcreator @claude
test(search-bar): re-record the dark placeholder reference
306b391 
Rendered by the CI snapshot job for the searchPlaceholder change; the old
reference had recorded the unreadable placeholder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SearchBar: the placeholder is invisible in dark mode

2 participants

@ross-dash @optimisticcreator