Repository navigation
fix(nix): restore worker-build and lld in the devshell - #39
Open
Farhan (farhankhalaf) wants to merge 1 commit into
Open
Farhan (farhankhalaf) wants to merge 1 commit into
Farhan (farhankhalaf) wants to merge 1 commit into
Conversation
PR #38 added pkgs.worker-build and pkgs.lld so `alchemy deploy` and `alchemy dev` of packages/infra can build crates/cloudflare-worker-example. PR #37 merged 92 seconds later and rewrote the package list, dropping both. On main the devshell has no worker-build, so the RustCloudflareWorkerBuild step fails on a fresh checkout, and nixpkgs rustc cannot link wasm32 without lld. Add both back, gated on the worker crate being present so library template slices without it stay lean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RdyTmsnUzihkE8KMmq9qHo
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
Codex (@codex) review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback". |
Farhan (farhankhalaf)
requested review from
cooper (czxtm) and
Scott McMaster (scottmcmaster)
October 28, 2026 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores
pkgs.worker-buildandpkgs.lldin the devshell. #38 added them forcrates/cloudflare-worker-example; #37 merged 92 seconds later, rewrote the package list and dropped both. The crate README and AGENTS.md still say the devshell provides them.Gated on the worker crate rather than on
hasRust, so a template slice without the crate does not pull the wasm tooling. Thenix-rust-libslice copies all ofcrates/, so it keeps the tools.Evidence
nix eval .#devShells.aarch64-darwin.default.nativeBuildInputs):git treefmt bun nodejs cargo rustc rustfmt clippy rust-analyzer prelude age jq kubectl kustomize sops yq-go(no worker-build, no lld)lld worker-builderror: linker `lld` not found.worker-build --releaseincrates/cloudflare-worker-examplesucceeds (build/index.js+index_bg.wasm).alejandra --check nix/flake/devShells/default.nix: passes.Not run: a full
nix developof this repo on darwin. Thepreludederivation build hung locally on both main and this branch, which is unrelated to this change.Merge Danger
Door: two-way
Revert removes two packages from the devshell again.
Blast Radius: devshell
Adds lld and worker-build to
nix developwhen the worker crate exists. CI is unaffected apart fromnix flake checkevaluating the shell.🤖 Generated with Claude Code
https://claude.ai/code/session_01RdyTmsnUzihkE8KMmq9qHo