Skip to content

test: make AppendFormat provider tests independent of ICU culture data #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samtrion wants to merge 1 commit into from
Closed

test: make AppendFormat provider tests independent of ICU culture data #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions tests/NetEvolve.CodeBuilder.Tests.Unit/CSharpCodeBuilderTests.AppendFormat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@

public partial class CSharpCodeBuilderTests
{
// Built explicitly so the tests do not depend on ICU culture data (DOTNET_SYSTEM_GLOBALIZATION_INVARIANT).
private static readonly NumberFormatInfo _commaDecimalFormat = new()
{
NumberDecimalSeparator = ",",
NumberGroupSeparator = ".",
};

[Test]
public async Task AppendFormat_OneArgument_Should_Format_Correctly()
{
Expand Down Expand Up @@ -309,21 +316,18 @@ public void AppendFormat_EmptyArray_ThrowsFormatException()
public async Task AppendFormat_WithProvider_OneArgument_Should_Format_Correctly()
{
var builder = new CSharpCodeBuilder(10);
var cultureInfo = new CultureInfo("de-DE");

_ = builder.AppendFormat(cultureInfo, "Value: {0:N2}", 1234.56);
_ = builder.AppendFormat(_commaDecimalFormat, "Value: {0:N2}", 1234.56);

// French culture uses comma as decimal separator
_ = await Assert.That(builder.ToString()).IsEqualTo("Value: 1.234,56");
}

[Test]
public async Task AppendFormat_WithProvider_TwoArguments_Should_Format_Correctly()
{
var builder = new CSharpCodeBuilder(10);
var cultureInfo = new CultureInfo("de-DE");

_ = builder.AppendFormat(cultureInfo, "Values: {0:N2}, {1}", 1234.56, "test");
_ = builder.AppendFormat(_commaDecimalFormat, "Values: {0:N2}, {1}", 1234.56, "test");

_ = await Assert.That(builder.ToString()).IsEqualTo("Values: 1.234,56, test");
}
Expand All @@ -332,9 +336,8 @@ public async Task AppendFormat_WithProvider_TwoArguments_Should_Format_Correctly
public async Task AppendFormat_WithProvider_ThreeArguments_Should_Format_Correctly()
{
var builder = new CSharpCodeBuilder(10);
var cultureInfo = new CultureInfo("de-DE");

_ = builder.AppendFormat(cultureInfo, "Values: {0:N2}, {1}, {2}", 1234.56, "test", true);
_ = builder.AppendFormat(_commaDecimalFormat, "Values: {0:N2}, {1}, {2}", 1234.56, "test", true);

_ = await Assert.That(builder.ToString()).IsEqualTo("Values: 1.234,56, test, True");
}
Expand All @@ -343,9 +346,8 @@ public async Task AppendFormat_WithProvider_ThreeArguments_Should_Format_Correct
public async Task AppendFormat_WithProvider_ParamsArray_Should_Format_Correctly()
{
var builder = new CSharpCodeBuilder(10);
var cultureInfo = new CultureInfo("de-DE");

_ = builder.AppendFormat(cultureInfo, "Values: {0:N2}, {1}, {2}, {3:F2}", 1234.56, "test", true, 3.14);
_ = builder.AppendFormat(_commaDecimalFormat, "Values: {0:N2}, {1}, {2}, {3:F2}", 1234.56, "test", true, 3.14);

_ = await Assert.That(builder.ToString()).IsEqualTo("Values: 1.234,56, test, True, 3,14");
}
Expand All @@ -358,7 +360,9 @@ public async Task AppendFormat_WithProvider_NullProvider_Should_Use_CurrentCultu

try
{
CultureInfo.CurrentCulture = new CultureInfo("de-DE");
var culture = (CultureInfo)CultureInfo.InvariantCulture.Clone();
culture.NumberFormat = _commaDecimalFormat;
CultureInfo.CurrentCulture = culture;
#pragma warning disable S3220 // Method calls should not resolve ambiguously to overloads with "params"
_ = builder.AppendFormat(null, "Value: {0:N2}", 1234.56);
#pragma warning restore S3220 // Method calls should not resolve ambiguously to overloads with "params"
Expand Down
Loading