Repository navigation
style(tests): remove code regions from Scope tests - #441
Merged
samtrion merged 1 commit intoOct 29, 2026
Merged
Conversation
decisions/2026-01-21-no-code-regions.md (accepted, applyTo **/*.cs) forbids code regions. CSharpCodeBuilderTests.Scope.cs still contained two #region/#endregion pairs. Remove the four directives; no behavior change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 15 15
Lines 340 340
Branches 100 100
=======================================
Hits 312 312
Misses 17 17
Partials 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
samtrion
deleted the
style/stryker-region-violates-no-code-regions-adr-1
branch
October 29, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
decisions/2026-01-21-no-code-regions.md(state: accepted, applyTo**/*.cs) says code regions MUST NOT be used.tests/NetEvolve.CodeBuilder.Tests.Unit/CSharpCodeBuilderTests.Scope.csstill has two region pairs (#regionat lines 7 and 143,#endregionat lines 141 and 436), i.e. 4 directives. No other#regionexists insrcortests.Root cause
The file was never cleaned up after the ADR was accepted.
Change
Delete the four directives and the blank lines around them. No other edit; UTF-8 BOM kept.
Before / After
#region/#endregiondirectivesRisk / what this does not change
Hygiene only. Test code is not mutated, so no improvement of the mutation baseline is expected; the mutation run is only a sanity check that nothing changed.