Skip to content

(Claude) Gate oxfmt formatting in CI; ignore the reformat in git blame - #358

Merged
cboos merged 1 commit into
mainfrom
dev/oxfmt-gate
Oct 9, 2026
Merged

cboos merged 1 commit into
mainfrom
dev/oxfmt-gate

Conversation

@cboos

@cboos cboos commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

The last of three oxfmt PRs, after #356 (the tooling) and #357 (the reformat).

  • Gate. just fmt-check joins just ci, and CI runs the same two checks (oxfmt --check and scripts/fmt_templates.py --check) on the primary job, after the JavaScript lint step. Both run before the step fails, so every unformatted file is listed.
  • Blame. .git-blame-ignore-revs names (Claude) Reformat JS, CSS, JSON and YAML with oxfmt #357's commit. GitHub's blame view reads it on its own; locally, git config blame.ignoreRevsFile .git-blame-ignore-revs turns it on. On minimal_dag.js (2320 lines), the lines blamed on the reformat go from 2255 to 243; the rest are lines the reformat created (split lines and the like), which git can't map back to older ones.
  • Docs. CONTRIBUTING's formatting section says the check is gated, to run just fmt-js before committing, and how to set up blame.

Checked: the step's commands, run with a badly formatted line in a plain JS file and in a Jinja template file, fail in each case and pass on the clean tree; just ci passes.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added automated formatting checks for JavaScript, CSS, JSON, and YAML to local and CI workflows.
    • Updated contributor guidance for formatting checks and Git blame.

`just fmt-check` joins `just ci`, and CI runs the same two checks on
the primary job, after lint-js; both run, so every unformatted file is
listed. `.git-blame-ignore-revs` names the reformat commit (#357), and
CONTRIBUTING says how to point `git blame` at it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2ac4b2a5-96ed-45c0-b6f1-a1c07a015e10

📥 Commits

Reviewing files that changed from the base of the PR and between 8ae38e5 and 806c03b.


📒 Files selected for processing (4)
  • .git-blame-ignore-revs
  • .github/workflows/ci.yml
  • CONTRIBUTING.md
  • justfile

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.



📝 Walkthrough

Walkthrough

The just ci target and primary CI job now run formatting checks. Contributor documentation describes how to run the formatter and configure blame to ignore the formatting commit.

Changes

Formatting checks

Layer / File(s) Summary
Run formatting checks in CI
justfile, .github/workflows/ci.yml
The ci target runs fmt-check between lint-js and ty. The primary CI job runs oxfmt --check and scripts/fmt_templates.py --check.
Document formatting and blame guidance
CONTRIBUTING.md, .git-blame-ignore-revs
Contributor guidance covers formatting checks, running the formatter, and configuring blame to ignore the formatting commit. The blame ignore file lists that commit.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: daaain


Merge Risk: ⚪ Minimal · up to 806c0

The supplied changes introduce no actionable merge risk; the formatting gate and contributor guidance appear aligned with the stated workflow.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes both primary changes: enforcing oxfmt formatting in CI and excluding the reformat commit from Git blame.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cboos
cboos merged commit 9834d25 into main Oct 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant