Repository navigation
(Claude) Gate oxfmt formatting in CI; ignore the reformat in git blame - #358
Conversation
`just fmt-check` joins `just ci`, and CI runs the same two checks on the primary job, after lint-js; both run, so every unformatted file is listed. `.git-blame-ignore-revs` names the reformat commit (#357), and CONTRIBUTING says how to point `git blame` at it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe ChangesFormatting checks
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The supplied changes introduce no actionable merge risk; the formatting gate and contributor guidance appear aligned with the stated workflow. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The last of three oxfmt PRs, after #356 (the tooling) and #357 (the reformat).
just fmt-checkjoinsjust ci, and CI runs the same two checks (oxfmt --checkandscripts/fmt_templates.py --check) on the primary job, after the JavaScript lint step. Both run before the step fails, so every unformatted file is listed..git-blame-ignore-revsnames (Claude) Reformat JS, CSS, JSON and YAML with oxfmt #357's commit. GitHub's blame view reads it on its own; locally,git config blame.ignoreRevsFile .git-blame-ignore-revsturns it on. Onminimal_dag.js(2320 lines), the lines blamed on the reformat go from 2255 to 243; the rest are lines the reformat created (split lines and the like), which git can't map back to older ones.just fmt-jsbefore committing, and how to set up blame.Checked: the step's commands, run with a badly formatted line in a plain JS file and in a Jinja template file, fail in each case and pass on the clean tree;
just cipasses.🤖 Generated with Claude Code
Summary by CodeRabbit