Skip to content

fix: Renovate: lock file maintenance fails in Yarn Modern - #1926

Closed
Roshan931 wants to merge 1 commit into
cypress-io:masterfrom
Roshan931:prilog/fix-error-invalid-matchfilenames-pattern-in-10-10-2026-4ec772
Closed

Roshan931 wants to merge 1 commit into
cypress-io:masterfrom
Roshan931:prilog/fix-error-invalid-matchfilenames-pattern-in-10-10-2026-4ec772

Conversation

@Roshan931

Copy link
Copy Markdown

Fixes #1910

Root cause

Invalid matchFileNames pattern in Renovate lockFileMaintenance exclusion

Changes

  • Replaced the regex-style path string '/^examples/yarn-modern/' with the glob patterns 'examples/yarn-modern/' and 'examples/yarn-modern-pnp/' so the lockFileMaintenance disable rule actually matches both Yarn Modern examples.

Signed-off-by: Robert Markovski <5818108+Roshan931@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MikeMcC399

Copy link
Copy Markdown
Collaborator

https://agentscan.tools/user/roshan931
Automation detected

@MikeMcC399

Copy link
Copy Markdown
Collaborator

This PR claims to fix #1910. This issue is a Renovate bug that appears when both Yarn v1 Classic and Yarn v4 Modern are configured for Renovate lock file maintenance.

The bug was reported to Renovate under renovatebot/renovate#46381. There has not been any response from Renovate, and so the issue remains unresolved.

PR #1909 implemented a workaround to exclude /^examples/yarn-modern/ which matches the two Yarn Modern examples examples/yarn-modern and examples/yarn-modern-pnp.

The latest lock file maintenance PR #1924 (which uses the workaround) is merged. It correctly updated yarn.lock files for Yarn v1 Classic and skipped lock files for Yarn v4 modern.

@MikeMcC399

Copy link
Copy Markdown
Collaborator

@Roshan931

Please do not target this repo in future.

The root cause analysis is incorrect. There is nothing wrong with the RegEx pattern. Changing it to individual glob patterns has no effect. Nothing is resolved by this PR.

Closing as invalid.

@MikeMcC399 MikeMcC399 closed this Oct 10, 2026
@MikeMcC399 MikeMcC399 added the invalid This doesn't seem right label Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renovate: lock file maintenance fails in Yarn Modern

3 participants