Repository navigation
Upgrade AGP to 9.5.1 - #135
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Default setup's autobuild ran ./gradlew testClasses, which only compiled
the empty root project, so :app was never analyzed. That task no longer
exists after removing the root kotlin("jvm") plugin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades the Android Gradle Plugin from 8.8.2 to 9.5.1, with only the changes AGP 9 requires. Most of the open Dependabot PRs fail because they need AGP 9. This PR is kept minimal so they can merge afterward.
Changes Made
org.jetbrains.kotlin.androidplugin, which AGP 9 replaces, and the unused rootkotlin("jvm")plugin. Kotlin is 2.2.10, the lowest version AGP 9 accepts; Dependabot can bump it from here.jvmTargetmoved fromkotlinOptionstokotlin { compilerOptions { ... } }.composeOptions.kotlinCompilerExtensionVersion, which Kotlin 2.x ignores.libs.versions.toml..github/workflows/codeql.yml). Default setup's autobuild ran./gradlew testClasses, which only compiled the empty root project (every task reportedNO-SOURCE), so:appwas never analyzed. That task no longer exists without the rootkotlin("jvm")plugin. The new workflow writesgoogle-services.jsonfrom the secret and buildsassembleDebugplus the unit tests, so CodeQL analyzes the real app code. Default setup has been turned off in repo settings.Test Coverage
./gradlew assembleDebug lint testDebugUnitTestpasses locally on JDK 17.Next Steps
After this merges, comment
@dependabot rebaseon:#132 (Hilt 2.60.1) is already covered here. #133 bumped the root
kotlin("jvm")plugin, which this PR removes. Dependabot should close both on its own.Related PRs or Issues
Unblocks #130, #131, #132, #133, #134.
🤖 Generated with Claude Code