Skip to content

[fips-8] github actions: Fix upstream commit check for forks - #541

Merged
bmastbergen merged 2 commits into
ctrliq:fips-8-compliant/4.18.0-553.16.1from
bmastbergen:bmastbergen_fips-8-compliant/4.18.0-553.16.1-upstream-commit-checker-forked
Sep 4, 2025
Merged

bmastbergen merged 2 commits into
ctrliq:fips-8-compliant/4.18.0-553.16.1from
bmastbergen:bmastbergen_fips-8-compliant/4.18.0-553.16.1-upstream-commit-checker-forked

Conversation

@bmastbergen

Copy link
Copy Markdown
Collaborator

The upstream commit check workflow was failing for pull requests originating from forked repositories. The previous implementation incorrectly assumed the pull request branch existed on the base repository.

This commit corrects the workflow to ensure the pull request branch is checked out from the correct source repository, while the base branch is fetched from the target repository.

The upstream commit check workflow was failing for pull requests
originating from forked repositories. The previous implementation
incorrectly assumed the pull request branch existed on the base repository.

This commit corrects the workflow to ensure the pull request branch
is checked out from the correct source repository, while the base
branch is fetched from the target repository.
The process-pull-request workflow was failing for pull requests
originating from forked repositories. The previous implementation
incorrectly assumed the pull request branch existed on the base repository.

This commit corrects the workflow to ensure the pull request branch
is checked out from the correct source repository, while the base
branch is fetched from the target repository.

@PlaidCat PlaidCat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bmastbergen
bmastbergen merged commit fbb8ea1 into ctrliq:fips-8-compliant/4.18.0-553.16.1 Sep 4, 2025
4 checks passed
@bmastbergen
bmastbergen deleted the bmastbergen_fips-8-compliant/4.18.0-553.16.1-upstream-commit-checker-forked branch September 4, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants