Repository navigation
[feat] make min-reserved-fds configurable at runtime - #460
Open
qiongtubao wants to merge 1 commit into
Open
qiongtubao wants to merge 1 commit into
qiongtubao wants to merge 1 commit into
Conversation
qiongtubao
force-pushed
the
feature/dynamic_change_min_reserved_fds
branch
4 times, most recently
from
October 28, 2026 12:19
28de44b to
5122344
Compare
Move the FD-budget raise logic into raiseOpenFilesLimit() so that both maxclients and min-reserved-fds share the same runtime callback. The shared updateOpenFilesLimit() recomputes the event-loop setsize from both values, raises RLIMIT_NOFILE when needed, and resizes the ae event loop. Rollback is handled by the existing configs framework. Cover the new behavior with unit tests in tests/unit/limits.tcl and drop min-reserved-fds from the immutable skip list in tests/unit/introspection.tcl.
qiongtubao
force-pushed
the
feature/dynamic_change_min_reserved_fds
branch
from
October 28, 2026 12:38
5122344 to
f0c8f1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the FD-budget raise logic into raiseOpenFilesLimit() so that both maxclients and min-reserved-fds share the same runtime callback. The shared updateOpenFilesLimit() recomputes the event-loop setsize from both values, raises RLIMIT_NOFILE when needed, and resizes the ae event loop. Rollback is handled by the existing configs framework.
Cover the new behavior with unit tests in tests/unit/limits.tcl and drop min-reserved-fds from the immutable skip list in tests/unit/introspection.tcl.