Repository navigation
feat(api): add attendance and repeat check-in helpers - #9
Merged
Merged
Conversation
Collaborator
|
Nice work Harsha. The rule is correct: at or after the start, on the same Eastern calendar day, using One small note: Good to merge. |
VidurShah
force-pushed
the
feat/check-in-helpers
branch
from
October 22, 2026 04:37
c016bc5 to
ce0b431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #5
What changed
I added two functions:
didAttendchecks if someone checked in after a meeting started and before midnight Eastern time.mergeCheckInscombines two check-ins, keeping the latest information without losing previous attendance.I also added 25 tests covering normal check-ins, midnight, daylight saving time, invalid dates, and repeat check-ins.
How to verify
All tests and checks passed locally:
Checklist