Repository navigation
Sean/api errors validation - #8
Merged
Merged
Conversation
2 of 3 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Great work Sean. This covers everything in the ticket, and the tests are thorough. The production-mode 500 test and the type tests against the real web client are especially nice. A few small notes. None of them block merging:
Good to merge. |
VidurShah
approved these changes
Oct 22, 2026
VidurShah
pushed a commit
that referenced
this pull request
Oct 22, 2026
* feat(shared): define standard API error contract * feat(api): add centralized error handling * feat(api): add typed JSON and query validation * docs(api): note that unmapped HTTPException statuses become a 500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4
What changed
Why
Give API routes consistent error responses and reusable request validation, following TDD §3.2.
How to verify
Run from the repository root:
All passed locally, including 25 tests.
Screenshots
Not applicable; no UI changes.
Checklist