Repository navigation
Conversation
VidurShah
reviewed
Oct 22, 2026
VidurShah
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Anuj, this is close. The schema matches TDD 2.1/3.1, the seed is idempotent with onConflictDoNothing on name, and the README has the new command.
Please fix
updated_atnever changes. It getsdefaultNow()on insert, but nothing updates it after that. Add.$onUpdate(() => new Date())so Drizzle sets it on every update.seat_limithas no lower bound. Add a check constraint so it's either NULL (unlimited) or greater than 0. A seat limit of 0 or less would block every assignment.- Developer position name. It's seeded as
"Developer (backend / frontend / fullstack)". Make it just"Developer". The subrole is stored separately inmember_positions.dev_subrole(TDD 3.1), so it shouldn't be part of the name.
Heads-up
- Migration clash with #12. #12 also adds a
0001_*migration. If this merges first, #12 will regenerate on top of it, so you shouldn't need to do anything. If #12 lands first, delete your migration files, rebase onmain, and runbun run db:generateagain. Don't edit the journal by hand. - PR checklist. It's unchecked. Please run through it (CI passes locally, TDD
‼️ markers removed for positions, no secrets) and tick the boxes.
Re-request review when it's ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #2
What changed
Why
Adding positions to database will allow members to be assigned positions
How to verify
No duplicate rows are added
Screenshots
No UI changes
Checklist