Repository navigation
Conversation
Add GET /api/v2/solver_competition/{auction_id} and
/api/v2/solver_competition/by_tx_hash/{tx_signature}, reading the
competition tables the autopilot persists. A competition stays hidden
until the current auction's tip slot passes its deadline slot.
|
Reminder: Please consider backward compatibility when modifying the API specification.
Caused by: |
Author
|
I just wanted to check the changes needed to expose it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solvers, accounting and the explorer can't see who bid what on Solana.
The autopilot persists every competition the db. This PR is about exposing it.
Linear: BE-315
Changes
Exposes the endpoints and swagger docs for:
GET /api/v2/solver_competition/{auction_id}GET /api/v2/solver_competition/by_tx_hash/{tx_signature}.The response has the same shape as the EVM except:
auctionStartSlot/auctionDeadlineSlotinstead of blockstransactionSignatures/txSignature(base58) instead of hashesclearingPricesorfastPath, because the Solana tables have neither. (for now)Visibility:
tip_slotinsolana.auctionspasses itsdeadline_slot, so solutions are never shown while they can still be submitted. EVM does the same withhide_competition_before_block.Out of scope
txSignaturestaysnulluntil the outcome verifier (BE-197) fillssettlements.solution_uid.Open questions for review:
by_tx_hashfor client parity, even though the parameter is a signature. Happy to rename it toby_tx_signature.latestand the unfiltered/restrictedvariant are not included, because BE-315 doesn't ask for them.How to test
Against staging once deployed: