Repository navigation
Views: reclaim unused call-graph bases, count bases toward callgraph_copies, reclaim before refusing at the disk floor - #1305
Merged
Conversation
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
…enced-bases Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Git for Windows ships a system gitattributes file. Its presence correctly disables reusable tree proofs, so these fixtures built membership bases and admission reserved a second database instead of reusing the main base. Shared bases still counted once, and deterministic LRU timestamps were ordered correctly; the extra reservation caused early borrowing and eviction of the newest idle base. Use the existing thread-local absent-attribute-sources guard for the shared fixture and the original copy-limit test. Keep the guard alive through all reads and admissions. This makes their shared-tree-base premise deterministic without changing product behavior, assertions, waits, or eviction protections. Native Windows baseline: 4 passed, 3 failed, including the original #1254 test. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Reorders AFT's v3 retention so unreferenced bases are reclaimed before the accounting walk, and makes the root-history census bounded and resumable, so storage cleanup no longer stalls on long project histories. Also counts call-graph bases against
views.callgraph_copiesand reclaims unused databases before refusing a write for low free space.Written for commit d0c79a9. Summary will update on new commits.