Repository navigation
chore(deps): apply npm audit fix and fix ForgotPassword rate-limit test - #193
Merged
Merged
Conversation
Bump shadcn 4.21.4 -> 4.22.1 (with @shadcn/registry 0.2.0), concurrently 10.0.5 -> 10.0.6 and shell-quote 1.9.0 -> 1.12.0 via npm audit fix, and align the lockfile version with package.json (0.2.3). The braces advisory GHSA-vfj7-8cjw-p6xm (7 high-severity findings, all reached transitively through shadcn) has no patched release upstream and is intentionally left as is. Also update the ForgotPassword rate-limit test: since #191 the input uses the shared Field, which omits aria-invalid when there is no field-level error. Assert its absence instead of aria-invalid="false". Signed-off-by: Marek Dano <mk.dano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies
npm audit fix, which updatespackage-lock.jsononly;package.jsonis unchanged.shadcn4.21.4 → 4.22.1 (with@shadcn/registry0.1.3 → 0.2.0)concurrently10.0.5 → 10.0.6shell-quote1.9.0 → 1.12.0version0.2.2 → 0.2.3, to matchpackage.jsonFixes a failing test in
ForgotPassword.test.tsx. Since refactor(auth): use shared Field in Login, ForgotPassword and PasswordChangeRequired #191,ForgotPassworduses the sharedField, which omitsaria-invalidwhen there is no field-level error. The 429 rate-limit error is form-level, so the test now asserts the attribute is absent instead of"false".Not addressed
npm auditstill reports 7 high-severity findings, all from GHSA-vfj7-8cjw-p6xm inbraces@3.0.3, reached throughshadcn→fast-glob→micromatch→braces.npm audit fix --forcewould downgradeshadcnto 1.0.0, so it was not used.shadcnis only used for its build-time CSS import and the CLI, and nothing feedsbracesuntrusted patterns.npm audit fixonce a fix ships or the advisory is corrected.Notes
shadcnand@shadcn/registrynow resolve a nestedzod@4. The app's ownzodstays on 3.25.libcfields on optional native packages (local npm version difference); this has no effect on installs.ForgotPasswordtest failure was already present onmain, independent of the dependency bumps.Test plan
src/pages/ForgotPassword.test.tsxpassednpm run testpassednpm cinpm run buildnpm run lint