Skip to content

chore(deps): apply npm audit fix and fix ForgotPassword rate-limit test - #193

Merged
vishu-bh merged 1 commit into
mainfrom
fix-npm-vulns-and-unit-test
Oct 19, 2026
Merged

vishu-bh merged 1 commit into
mainfrom
fix-npm-vulns-and-unit-test

Conversation

@marekdano

Copy link
Copy Markdown
Contributor

Summary

  • Applies npm audit fix, which updates package-lock.json only; package.json is unchanged.

    • shadcn 4.21.4 → 4.22.1 (with @shadcn/registry 0.1.3 → 0.2.0)
    • concurrently 10.0.5 → 10.0.6
    • shell-quote 1.9.0 → 1.12.0
    • Lockfile version 0.2.2 → 0.2.3, to match package.json
  • Fixes a failing test in ForgotPassword.test.tsx. Since refactor(auth): use shared Field in Login, ForgotPassword and PasswordChangeRequired #191, ForgotPassword uses the shared Field, which omits aria-invalid when there is no field-level error. The 429 rate-limit error is form-level, so the test now asserts the attribute is absent instead of "false".

Not addressed

npm audit still reports 7 high-severity findings, all from GHSA-vfj7-8cjw-p6xm in braces@3.0.3, reached through shadcn → fast-glob → micromatch → braces.

Notes

  • shadcn and @shadcn/registry now resolve a nested zod@4. The app's own zod stays on 3.25.
  • The lockfile also loses the libc fields on optional native packages (local npm version difference); this has no effect on installs.
  • The ForgotPassword test failure was already present on main, independent of the dependency bumps.

Test plan

  • src/pages/ForgotPassword.test.tsx passed
  • Full npm run test passed
  • npm ci
  • npm run build
  • npm run lint

  Bump shadcn 4.21.4 -> 4.22.1 (with @shadcn/registry 0.2.0),
  concurrently 10.0.5 -> 10.0.6 and shell-quote 1.9.0 -> 1.12.0 via
  npm audit fix, and align the lockfile version with package.json (0.2.3).

  The braces advisory GHSA-vfj7-8cjw-p6xm (7 high-severity findings, all
  reached transitively through shadcn) has no patched release upstream and
  is intentionally left as is.

  Also update the ForgotPassword rate-limit test: since #191 the input uses
  the shared Field, which omits aria-invalid when there is no field-level
  error. Assert its absence instead of aria-invalid="false".

Signed-off-by: Marek Dano <mk.dano@gmail.com>

@vishu-bh vishu-bh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vishu-bh
vishu-bh merged commit 289c1c7 into main Oct 19, 2026
5 checks passed
@vishu-bh
vishu-bh deleted the fix-npm-vulns-and-unit-test branch October 19, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants