Skip to content

perf(bindx-client): declare TEntity invariant on selection builder methods #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matej21 merged 1 commit into from
Oct 24, 2026
Merged

perf(bindx-client): declare TEntity invariant on selection builder methods #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/bindx-client/src/selection/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ export interface FluentFragment<
/**
* Scalar method on selection builder - selects a scalar field
*/
export interface ScalarMethod<TEntity, K extends keyof TEntity, TSelected extends object, THasManyParams extends object> {
// TEntity is declared `in out` on all three *Method interfaces. Measured instead, it cycles through the `-?` mapped
// type in SelectionBuilderMethods and comes out unmeasurable, so TypeScript 7.1 compares builders structurally:
// quadratic in the entity's field count, TS2589 on large schemas.
export interface ScalarMethod<in out TEntity, K extends keyof TEntity, TSelected extends object, THasManyParams extends object> {
/** Select field with original name */
(): SelectionBuilder<TEntity, TSelected & Pick<TEntity, K>, THasManyParams>
/** Select field with alias */
Expand All @@ -109,7 +112,7 @@ export interface ScalarMethod<TEntity, K extends keyof TEntity, TSelected extend
* Has-one method on selection builder - selects a relation to single entity
*/
export interface HasOneMethod<
TEntity,
in out TEntity, // see ScalarMethod
K extends keyof TEntity,
TRelated,
TSelected extends object,
Expand Down Expand Up @@ -175,7 +178,7 @@ type ResolveAlias<K, TOptions> = TOptions extends { as: infer A extends string }
* Has-many method on selection builder - selects a relation to multiple entities
*/
export interface HasManyMethod<
TEntity,
in out TEntity, // see ScalarMethod
K extends keyof TEntity,
TItem,
TSelected extends object,
Expand Down
Loading