Repository navigation
Conversation
A source that has been unlinked after being bind-mounted can still be opened, but the bind mount syscall fails with ENOENT. Treat that as a missing source for try-bind operations. Add a regression test for a bind-mounted file whose original path is deleted. Fixes: containers#811 Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--bind-trycurrently fails if its source was bind-mounted and then unlinked: opening the source succeeds, but the latermount()returnsENOENT. Treat that mount error as an absent source for try-bind operations.Add a regression test that runs a nested bind-try before and after unlinking the original file.
Validation on Fedora 44 aarch64:
meson compile -C build;meson test -C build --print-errorlogs(5 passed, 1 skipped because seccomp is unavailable). The new regression fails with the original binary and passes with the fix.