You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[URGENT] Regression? TestRunWithTtyAndDetached on windows appears broken on main #3437
changed the title [-][URGENT] Regression? TestRunWithTtyAndDetached is broken[/-][+][URGENT] Regression? TestRunWithTtyAndDetached is broken on main[/+]on Sep 18, 2024
changed the title [-][URGENT] Regression? TestRunWithTtyAndDetached is broken on main[/-][+][URGENT] Regression? TestRunWithTtyAndDetached on windows is broken on main[/+]on Sep 18, 2024
changed the title [-][URGENT] Regression? TestRunWithTtyAndDetached on windows is broken on main[/-][+][URGENT] Regression? TestRunWithTtyAndDetached on windows appears broken on main[/+]on Sep 18, 2024
@AkihiroSuda this is a major pita.
I know it is just a test, but it is failing incredibly often which begs the question of whether the code is really working.
I believe this should now be fixed with the merge of this PR into hcsshim: microsoft/hcsshim#2923. This means the fix should appear when updating to latest main branch for hcsshim, or alternatively v0.15.1 when that is eventually released.
Once hcsshim has been updated, it would be good to enable this test once again to catch any future regressions.
Activity
[-][URGENT] Regression? TestRunWithTtyAndDetached is broken[/-][+][URGENT] Regression? TestRunWithTtyAndDetached is broken on main[/+][-][URGENT] Regression? TestRunWithTtyAndDetached is broken on main[/-][+][URGENT] Regression? TestRunWithTtyAndDetached on windows is broken on main[/+]apostasie commentedon Sep 18, 2024
Note: github is experiencing network issues rn, so.......
[-][URGENT] Regression? TestRunWithTtyAndDetached on windows is broken on main[/-][+][URGENT] Regression? TestRunWithTtyAndDetached on windows appears broken on main[/+]apostasie commentedon Sep 19, 2024
https://github.com/containerd/nerdctl/actions/runs/10950055624/job/30404542869?pr=3435#step:8:473
apostasie commentedon Sep 20, 2024
https://github.com/containerd/nerdctl/actions/runs/10965099031/job/30450151113?pr=3418#step:8:565
apostasie commentedon Sep 21, 2024
https://github.com/containerd/nerdctl/actions/runs/10968930365/job/30460923241?pr=3446#step:8:473
apostasie commentedon Sep 21, 2024
https://github.com/containerd/nerdctl/actions/runs/10974186024/job/30472417850?pr=3435#step:9:476
apostasie commentedon Sep 26, 2024
@AkihiroSuda this is a major pita.
I know it is just a test, but it is failing incredibly often which begs the question of whether the code is really working.
Tagging for milestone v2?
TinaMor commentedon Sep 30, 2024
@apostasie Have you started investigating this? I'll pick this up this week.
apostasie commentedon Sep 30, 2024
Hey @TinaMor
Been merely poking the test w/o sleeps - no real work or new insight on my side (also I do not have a windows setup).
apostasie commentedon Oct 14, 2024
@TinaMor going to skip that test for the time being (#3541), until we figure out what's going on and can re-enable it.
mcayland-ntx commentedon Oct 23, 2026
I believe this should now be fixed with the merge of this PR into hcsshim: microsoft/hcsshim#2923. This means the fix should appear when updating to latest
mainbranch for hcsshim, or alternativelyv0.15.1when that is eventually released.Once hcsshim has been updated, it would be good to enable this test once again to catch any future regressions.