Skip to content

feat(cli): skip the online tool-versions data while the embedded data is current - #8084

Merged
viceice merged 1 commit into
viceice/refactor/resolver-monofrom
viceice/feat/resolver-offline
Oct 30, 2026
Merged

viceice merged 1 commit into
viceice/refactor/resolver-monofrom
viceice/feat/resolver-offline

Conversation

@viceice

@viceice viceice commented Oct 29, 2026

Copy link
Copy Markdown
Member

Changes

  • The resolver uses only the embedded tool-versions data while its release.json build time is younger than the max age, 24h by default.
  • CONTAINERBASE_RESOLVER_MAX_AGE sets the max age, parsed like Renovate durations (eg. 12h, 1 day 2h).
  • CONTAINERBASE_RESOLVER_OFFLINE=true stops all online tool-versions requests, for resolving and downloads; a version that isn't embedded downloads from the installer's own source.
  • Embedded data without release.json keeps today's behaviour, online data first.
  • Docs follow in the top layer of the stack.
  • Part of Resolve every tool's versions through the tool-versions data #7887.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Code and tests by Claude Code (Claude Opus 5.5), reviewed by @viceice.

Use of AI in replying to PR comments

Who answers review comments:

  • @viceice will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • An agent will draft replies and reply autonomously. This is heavily discouraged, and we prefer that there are humans in the loop
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified tests

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@viceice
viceice added this pull request to stack #8087 October 29, 2026 11:58
@viceice
viceice force-pushed the viceice/feat/resolver-offline branch from 55a3167 to 5a0929d Compare October 29, 2026 12:31
@viceice
viceice marked this pull request as ready for review October 29, 2026 12:37
@viceice
viceice force-pushed the viceice/feat/resolver-offline branch from 5a0929d to ef5f506 Compare October 29, 2026 14:17
@viceice
viceice force-pushed the viceice/feat/resolver-offline branch 2 times, most recently from 6ee5cef to dd2d78b Compare October 30, 2026 08:26
… is current

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
@viceice
viceice force-pushed the viceice/feat/resolver-offline branch from dd2d78b to a1d8fb4 Compare October 30, 2026 12:17
@viceice
viceice enabled stacked auto-merge October 30, 2026 13:01
@viceice
viceice added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 4d005ca Oct 30, 2026
104 of 118 checks passed
@viceice
viceice deleted the viceice/feat/resolver-offline branch October 30, 2026 13:38
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 14.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant