Skip to content

fix(node): keep the yarn global cache in the containerbase cache - #8024

Merged
viceice merged 1 commit into
viceice/feat/cleanup-allfrom
viceice/fix/yarn-berry-cache
Oct 27, 2026
Merged

viceice merged 1 commit into
viceice/feat/cleanup-allfrom
viceice/fix/yarn-berry-cache

Conversation

@viceice

@viceice viceice commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Link ~/.yarn into the containerbase cache like ~/.npm, so the yarn v2+ global cache lives in /tmp/containerbase/cache.
  • cleanup cache removes .yarn/berry/cache (yarn 2–5) and .yarn/zpm/cache (yarn 6).
  • The base path setup now also creates cache/.npm and cache/.yarn on every init (moved from node's init), so the links also work for tools like yarn 6 that don't start node's init; a link to a folder is kept, a dangling link is skipped.
  • Part of feature request: Integrate cleanup into the install-tool #4362.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Code, tests and docs by Claude Code (Claude Opus 5.5), reviewed by @viceice.

Use of AI in replying to PR comments

Who answers review comments:

  • @viceice will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • An agent will draft replies and reply autonomously. This is heavily discouraged, and we prefer that there are humans in the loop
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified tests

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d52bc780-ec0a-4dec-a38d-bba18115a30b
Commits

Reviewing files that changed from the base of the PR and between a66c200 and a4dcf0c.

Files selected for processing: 8
  • docs/tools.md
  • src/cli/services/path.service.spec.ts
  • src/cli/services/path.service.ts
  • src/cli/tools/node/index.spec.ts
  • src/cli/tools/node/index.ts
  • src/cli/tools/node/utils.spec.ts
  • src/cli/tools/node/utils.ts
  • test/node/Dockerfile
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@viceice
viceice added this pull request to stack #8019 October 26, 2026 15:23
@viceice
viceice force-pushed the viceice/fix/yarn-berry-cache branch from 6b4eeff to f1c5de3 Compare October 26, 2026 16:15
@viceice
viceice force-pushed the viceice/fix/yarn-berry-cache branch from f1c5de3 to 4a21436 Compare October 26, 2026 16:59
@viceice
viceice marked this pull request as ready for review October 26, 2026 17:05
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@viceice
viceice enabled stacked auto-merge October 26, 2026 17:06
Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
@viceice
viceice force-pushed the viceice/fix/yarn-berry-cache branch from 4a21436 to a4dcf0c Compare October 27, 2026 07:08
@viceice
viceice added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 56fe934 Oct 27, 2026
56 of 67 checks passed
@viceice
viceice deleted the viceice/fix/yarn-berry-cache branch October 27, 2026 08:31
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 14.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant