Repository navigation
Backport alternative Base64 alphabet warnings to Python 3.12 - #973
Closed
saakshaat-singh wants to merge 1 commit into
Closed
saakshaat-singh wants to merge 1 commit into
saakshaat-singh wants to merge 1 commit into
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/43939772964. Examine the logs at this URL for more detail. |
saakshaat-singh
force-pushed
the
ssingh/312-base64-backport
branch
from
November 16, 2026 19:28
95e89fc to
4c81188
Compare
saakshaat-singh
marked this pull request as ready for review
November 16, 2026 19:52
saakshaat-singh
requested review from
chrisburr,
isuruf,
jakirkham,
katietz,
mbargull,
msarahan,
ocefpaf,
pelson,
scopatz and
xhochy
as code owners
November 16, 2026 19:52
Member
|
I see no reason here that justifies overruling the upstream decision to not backport this. This PR doesn't even match the upstream fix in newer releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Python 3.12.16 silently accepts standard-alphabet characters when decoding with an alternative Base64 alphabet, the behavior tracked by CVE-2025-12781 and python/cpython#125346.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
This proposes a downstream backport of the warning behavior from python/cpython#141128, increments the Python 3.12.16 package build number, and adds installed-package checks for the warnings and decoded results.
For affected input,
b64decode(..., validate=True)emitsDeprecationWarning; non-strict and URL-safe decoding emitFutureWarning. Decoded bytes are preserved when warnings are not promoted to errors. This does not introduce unconditional rejection of standard-alphabet characters.Upstream context
CPython explicitly declined this backport for 3.12, explaining that even warnings could break existing applications. This PR asks conda-forge maintainers whether to accept that downstream compatibility difference. A warning backport alone does not establish that applications validate the intended alphabet or that vulnerability scanners will recognize the rebuilt package as remediated.
This proposal is separate from the mail-command backports in #972, which can be evaluated independently.
Validation
The complete patch series applies to a clean v3.12.16 checkout and reproduces the tested source tree while preserving the original 23 packaging patches. The focused Base64 suite completed 37 tests using the released conda-forge Python 3.12.16 interpreter. Installed-package checks verify warning categories and unchanged decoded bytes, and the recipe passes
conda-smithy recipe-lint. Full package builds remain for feedstock CI.Review and next steps
Testing
Possible downsides?
Applications treating warnings as errors may now reject inputs they previously accepted. This is the reason upstream declined the stable-branch backport; the change preserves permissive decoding when warnings are ignored.
Are Docs needed?