Repository navigation
Py315 winfix - #45
Merged
Merged
Py315 winfix#45
Conversation
…2026.10.09.13.11.31 Other tools: - conda-build 26.5.0 - rattler-build 0.66.1 - rattler-build-conda-compat 1.4.15
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Contributor
Author
|
Sorry to merge this without consulting you, @awvwgk, but I'm pretty confident with the import test and would like to confirm with psi4 before proposing upstream. |
4 tasks done
awvwgk
reviewed
Oct 12, 2026
| @@ -8,9 +8,11 @@ package: | |||
| source: | |||
| url: https://github.com/dftd3/simple-dftd3/archive/refs/tags/v{{ version }}.tar.gz | |||
Member
There was a problem hiding this comment.
The correct fix is to change this line to build from the sdist in the release, as it includes the parameters.toml as part of the Python package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Reset the build number to0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Patch due to the layout change https://conda-forge.org/blog/2026/09/03/python-315/#a-more-unixy-layout-on-windows