Repository navigation
Conversation
Scroll events dispatched before the scroll animation ended may be handled after it ended (debounced), and are ignored without updating the remembered size. If the container was resized during the animation, the next scroll event (e.g. scrolling up by the user) is mistaken as a resize while sticky, and it scrolls back to the end.
OEvgeny
force-pushed
the
fix-ignored-resize-after-scroll-animation
branch
from
October 16, 2026 20:32
32c3cd1 to
04db1e5
Compare
OEvgeny
pushed a commit
to microsoft/BotFramework-WebChat
that referenced
this pull request
Oct 16, 2026
- unknownAttachment.html: wait with @testduet/wait-for and expect. - scrollToTop(): clarify why scrolling again is needed, add a TODO to remove the retry after compulim/react-scroll-to-bottom#145 is released.
1 of 11 tasks
OEvgeny
added a commit
to microsoft/BotFramework-WebChat
that referenced
this pull request
Oct 16, 2026
* Move changelog entries merged after 4.19.2 to Unreleased #5865 and #5872 were merged after v4.19.2 was published (2026-10-09T05:20Z), but their entries were filed under 4.19.2. * Fix flaky scrollToTop and unknownAttachment tests - pageObjects.scrollToTop(): react-scroll-to-bottom ignores scroll events right after its animation ends without updating the sizes it remembers. The next scroll is mistaken as a resize while sticky and it scrolls back to the bottom. Scroll again (up to 3 attempts), like a user would. Fixes scrollToEndButton.containerSize.html failing ~15-25% under load (40/40 after). - unknownAttachment.html: the live region renders the activity 5-15 ms after the transcript, wait for the console.warn before asserting. * Remove checkAccessibility overrides from tests Replacing window.checkAccessibility disabled accessibility checks for whole tests. With the checker running: - 11 tests had obsolete overrides (no violations in any variant), removed. part-grouping/keyboard, navigation and position never ran with a variant, the overrides were dead code. - Known violations are now skipped explicitly with skipCheckAccessibility, scoped to the failing variants and snapshots, with a TODO: - part-grouping/status and index (copilot): part grouping remounts when its first activity changes, aria-activedescendant points to the removed group. - side-by-side: the deprecated Copilot custom variant puts non-articles in role="feed"; contrast in the View code dialog. - markdown/vnext/markdownStreaming: bot markdown "# Heading" renders a level-one heading (#4721). * Address review: use waitFor, link react-scroll-to-bottom fix - unknownAttachment.html: wait with @testduet/wait-for and expect. - scrollToTop(): clarify why scrolling again is needed, add a TODO to remove the retry after compulim/react-scroll-to-bottom#145 is released. --------- Co-authored-by: Eugene Olonov <eugeneolonov@microsoft.com>
2 of 11 tasks
OEvgeny
added a commit
to microsoft/BotFramework-WebChat
that referenced
this pull request
Nov 4, 2026
* Fix flaky scrollToEndButton.withEventActivities test The test scrolled up with a raw `scrollTop = 0` and a 1 s sleep. When the "Connecting..." bar goes away (400 ms notification debounce) while the initial scroll to the bottom is still animating, react-scroll-to-bottom ignores that scroll event and keeps the old size. The test's scroll is then taken as a resize while sticky and the transcript scrolls back to the bottom, so the next message is read and the "New messages" button never shows. Use pageObjects.scrollToTop(), which waits for the scroll to settle and scrolls again, as the other scrollToEndButton tests do (compulim/react-scroll-to-bottom#145). * Add the changelog fragment --------- Co-authored-by: Eugene Olonov <eugeneolonov@microsoft.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Specific changes
offsetHeightandscrollHeightscroll-up-after-resize-while-scrollingtest