Skip to content

Enable cpp11features tests that pass now with CppInterOp fix #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
guitargeek wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable cpp11features tests that pass now with CppInterOp fix #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ include(GNUInstallDirs)
# This option won't make a lot of sense since we only ship the shared library in site-packages
# Perhaps this should permanently be OFF and users can build their own CppInterOp if they want to run the tests?
option(CPPJIT_ENABLE_CPPINTEROP_TESTS "enable CppInterOp tests" OFF)
set(CPPINTEROP_GIT_REPOSITORY "https://github.com/compiler-research/CppInterOp.git" CACHE STRING "")
set(CPPINTEROP_GIT_TAG "d3c8cf7aff7796e1539582f8e52910f351a48977" CACHE STRING "")
set(CPPINTEROP_GIT_REPOSITORY "https://github.com/guitargeek/CppInterOp.git" CACHE STRING "")
set(CPPINTEROP_GIT_TAG "a871711a992863ee8a02b8a8d220a5944041b4f0" CACHE STRING "")
set(CPPINTEROP_SOURCE_DIR "" CACHE PATH
"Override default CppInterOp built by ExternalProject_Add, with a path to local CppInterOp source")

Expand Down
2 changes: 0 additions & 2 deletions test/test_cpp11features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,6 @@ def test14_shared_ptr_passing(self):
gc.collect()
assert TestSmartPtr.s_counter == 0

@mark.xfail(condition=IS_MAC, reason="Fails for MacOS 26")
def test15_unique_ptr_template_deduction(self):
"""Argument type deduction with std::unique_ptr"""

Expand All @@ -498,7 +497,6 @@ def test15_unique_ptr_template_deduction(self):
with raises(ValueError): # not an RValue
cppjit.gbl.UniqueTempl.returnptr[int](uptr_in)

@mark.xfail(condition=IS_MAC, reason="Fails on Mac platforms")
def test16_unique_ptr_moves(self):
"""std::unique_ptr requires moves"""

Expand Down
Loading