Repository navigation
fix(js_ruler): number serial arg keys again - #40
Merged
Merged
Conversation
Since 3fdd108 the result of the "arg" -> "arg_N" gsub is discarded, so s(arg, arg) becomes an object with duplicate "arg" keys and the JS parser keeps only one of the values (e.g. "mpls priority 7 0").
Owner
|
Thanks for catching this! Appreciate the regression test too. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 3fdd108 the result of the
arg -> arg_Ngsub is discarded, sos(arg, arg)becomes an object with duplicateargkeys and the JS parser keeps only one of the values (e.g.mpls priority 7 0).