Skip to content

fix(meta/json): a transaction creates a namespace's directory before locking it #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CMGS merged 2 commits into from
Oct 2, 2026
Merged

fix(meta/json): a transaction creates a namespace's directory before locking it #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bec5da
fix(meta/json): a transaction creates a namespace's directory before …
CMGS Oct 2, 2026
5668fa6
fix(cmd/core): create the json namespace directories once at store bo…
CMGS Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmd/core/metastore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,14 @@ func MetaStore(conf *config.Config) (meta.Store, error) {
if conf.MetaBackend == "" {
log.WithFunc("core.MetaStore").Info(ctx, "legacy json meta store in use; `cocoon meta convert` upgrades it to sqlite")
}
if s, err := metajson.Open(MetaJSONNamespaces(conf)...); err != nil {
nss := MetaJSONNamespaces(conf)
for _, ns := range nss {
if err := utils.EnsureDirs(filepath.Dir(ns.LockPath)); err != nil {
metaErr = err
return
}
}
if s, err := metajson.Open(nss...); err != nil {
metaErr = err
} else {
metaStore = s
Expand Down
19 changes: 19 additions & 0 deletions cmd/core/metastore_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import (
"testing"

"github.com/cocoonstack/cocoon/config"
"github.com/cocoonstack/cocoon/hypervisor"
"github.com/cocoonstack/cocoon/meta"
"github.com/cocoonstack/cocoon/utils"
)

Expand Down Expand Up @@ -39,6 +41,23 @@ func TestMetaStoreBootstrapsFreshRoot(t *testing.T) {
resetMetaStore()
}

func TestMetaStoreJSONFreshRootLocksPeerNamespace(t *testing.T) {
resetMetaStore()
conf := testConf(t)
conf.MetaBackend = config.MetaBackendJSON
s, err := MetaStore(conf)
if err != nil {
t.Fatalf("open fresh json root: %v", err)
}
ch := hypervisor.VMNamespaceName(string(config.HypervisorCloudHypervisor))
fc := hypervisor.VMNamespaceName(string(config.HypervisorFirecracker))
if err := s.Update(t.Context(), meta.Scope{Write: ch, Read: []string{fc}}, meta.CommitDurable, func(meta.Writer) error { return nil }); err != nil {
t.Fatalf("placement-shaped update on a fresh json root: %v", err)
}
CloseMetaStore(t.Context())
resetMetaStore()
}

func TestMetaStoreKeepsLegacyJSON(t *testing.T) {
resetMetaStore()
conf := testConf(t)
Expand Down
Loading