Skip to content

Run tests on PHP 8.5 and update test environment - #25

Merged
clue merged 1 commit into
clue:masterfrom
clue-labs:php8.5
Oct 18, 2026
Merged

clue merged 1 commit into
clue:masterfrom
clue-labs:php8.5

Conversation

@clue

@clue clue commented Oct 18, 2026

Copy link
Copy Markdown
Owner

This changeset updates the test environment to run the test suite on PHP 8.5, which deprecates the setAccessible() calls used in our tests.

Builds on top of #24, #23, reactphp/stream#179, reactphp/event-loop#282, and clue/framework-x#297

@clue clue added the new feature New feature or request label Oct 18, 2026
@clue clue added this to the v0.3.0 milestone Oct 18, 2026
@clue
clue requested a balanced review from Copilot October 18, 2026 13:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused compatibility and environment updates have no identified blocking issues.

No open issues 🎉

What changed in this PR

Updates the test environment for PHP 8.5 while preserving compatibility with older PHP versions.

Changes:

  • Adds PHP 8.5 to CI and updates the checkout action.
  • Raises minimum ReactPHP dependency versions.
  • Limits setAccessible() calls to PHP versions below 8.1.
File Description
tests/​TarDecoderTest.php Guards reflection calls to avoid PHP 8.5 deprecations.
composer.json Updates stream and event-loop dependency requirements.
.github/​workflows/​ci.yml Adds PHP 8.5 and updates checkout to v7.

Review effort: Balanced

@clue
clue merged commit 851d354 into clue:master Oct 18, 2026
15 checks passed
@clue
clue deleted the php8.5 branch October 18, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants