Skip to content

fix(supernova): remove ComboBox key workaround now that controlled value clearing works - #2072

Merged
ArtieReus merged 2 commits into
mainfrom
artie-fix-supernova-combobox-reset-state
Oct 9, 2026
Merged

fix(supernova): remove ComboBox key workaround now that controlled value clearing works#2072
ArtieReus merged 2 commits into
mainfrom
artie-fix-supernova-combobox-reset-state

Conversation

@ArtieReus

@ArtieReus ArtieReus commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes the comboBoxKey workaround in FilterSelect that was forcing ComboBox re-renders when clearing the filter value. This workaround is no longer needed because the underlying ComboBox component now properly handles controlled value clearing.

Changes Made

  • Removed comboBoxKey state variable from FilterSelect
  • Removed setComboBoxKey increment after filter selection
  • Removed key={comboBoxKey} prop from ComboBox
  • Removed related tests that verified the workaround behavior

Related Issues

Closes #1947

Screenshots (if applicable)

N/A - No visual changes

Testing Instructions

  1. pnpm i
  2. pnpm --filter @cloudoperators/juno-app-supernova test
  3. Manual test: In Supernova, select a filter label, then select a filter value - verify the ComboBox clears and is ready for the next selection

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@ArtieReus
ArtieReus requested review from a team and franzheidl as code owners October 8, 2026 12:59
@ArtieReus ArtieReus self-assigned this Oct 8, 2026
@changeset-bot

changeset-bot Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 35661c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ArtieReus ArtieReus linked an issue Oct 8, 2026 that may be closed by this pull request
[Bug](supernova): Filter input loses focus when clearing text with backspace #1947
Closed
@github-actions

github-actions Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-09 13:55 UTC

@ArtieReus ArtieReus added the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label Oct 8, 2026
@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Oct 8, 2026
@ArtieReus
ArtieReus force-pushed the artie-fix-supernova-combobox-reset-state branch from 87ec34c to 2000740 Compare October 8, 2026 13:07
@github-actions github-actions Bot removed the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Oct 8, 2026
@ArtieReus
ArtieReus added this pull request to stack #2073 October 8, 2026 13:08
@ArtieReus
ArtieReus force-pushed the artie-fix-supernova-combobox-reset-state branch from 2000740 to 1a81d9e Compare October 8, 2026 13:09
Copilot AI balanced review requested due to automatic review settings October 8, 2026 13:09
Copilot AI reviewed Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Oct 8, 2026
@franzheidl franzheidl mentioned this pull request Oct 8, 2026
Merged
6 of 7 tasks
franzheidl
franzheidl reviewed Oct 8, 2026
View reviewed changes
Comment thread apps/supernova/src/components/filters/FilterSelect.tsx
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Oct 9, 2026
@ArtieReus
ArtieReus force-pushed the artie-fix-supernova-combobox-reset-state branch from 5624a31 to e73aae6 Compare October 9, 2026 07:12
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Oct 9, 2026
@ArtieReus
ArtieReus force-pushed the artie-fix-supernova-combobox-reset-state branch from e73aae6 to 4cb47ff Compare October 9, 2026 08:31
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Oct 9, 2026
@ArtieReus
ArtieReus force-pushed the artie-fix-supernova-combobox-reset-state branch from 4cb47ff to a168234 Compare October 9, 2026 09:15
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Oct 9, 2026
@ArtieReus
ArtieReus force-pushed the artie-fix-supernova-combobox-reset-state branch from a168234 to cfab8e3 Compare October 9, 2026 13:40
@github-actions github-actions Bot removed the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Oct 9, 2026
@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Oct 9, 2026
franzheidl
franzheidl approved these changes Oct 9, 2026
View reviewed changes

@franzheidl franzheidl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from artie-fix-combobox-query-clearing to main October 9, 2026 13:50
@ArtieReus
fix(supernova): remove ComboBox key workaround now that controlled va…
9fa8d2b 
…lue clearing works

The ComboBox component now properly handles controlled value clearing,
so we no longer need to force re-renders with a key prop.

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus
chore(supernova): addeda comment explaining why the setTimeout is needed
35661c5 
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus
ArtieReus force-pushed the artie-fix-supernova-combobox-reset-state branch from cfab8e3 to 35661c5 Compare October 9, 2026 13:50
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Oct 9, 2026
@ArtieReus
ArtieReus merged commit 03c74ef into main Oct 9, 2026
24 checks passed
@ArtieReus
ArtieReus deleted the artie-fix-supernova-combobox-reset-state branch October 9, 2026 13:54
@github-actions github-actions Bot removed the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@franzheidl franzheidl franzheidl approved these changes
@edda edda edda approved these changes

Assignees

@ArtieReus ArtieReus

Labels

greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview`

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug](supernova): Filter input loses focus when clearing text with backspace

4 participants

@ArtieReus @franzheidl @edda